Skip to content

Commit fb0d38c

Browse files
author
pooya parsa
committed
feat: options.dev
1 parent 58c972f commit fb0d38c

File tree

6 files changed

+11
-7
lines changed

6 files changed

+11
-7
lines changed

docs/modules/workbox.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ workbox: {
2828

2929
(Object) Options to be passed to workbox before using it's modules. By default `debug` field will be set to `false` for production builds.
3030

31+
### `dev`
32+
33+
(Boolean) Enable workbox in dev mode of nuxt. (Disabled by default)
34+
3135
### `importScripts`
3236

3337
(Array) Additional scripts to be imported in service worker script. (Relative to `/`. Can be placed in `assets/` directory)

packages/workbox/lib/defaults.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ module.exports = {
44

55
config: {},
66

7+
dev: false,
8+
79
importScripts: [],
810

911
offline: true,

packages/workbox/lib/options.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ function getOptions (moduleOptions) {
2121

2222
// swTemplate
2323
if (!options.swTemplate) {
24-
options.swTemplate = path.resolve(__dirname, `../templates/sw${this.options.dev ? '.dev' : ''}.js`)
24+
const disabled = this.options.dev && !options.dev
25+
options.swTemplate = path.resolve(__dirname, `../templates/sw${disabled ? '.disable' : ''}.js`)
2526
}
2627

2728
// swDest
@@ -70,7 +71,7 @@ function getOptions (moduleOptions) {
7071
// Workbox Config
7172
if (!options.config.debug) {
7273
// Debug field is by default set to true for localhost domain which is not always ideal
73-
options.config.debug = this.options.dev
74+
options.config.debug = options.dev || this.options.dev
7475
}
7576

7677
return options

packages/workbox/templates/sw.dev.js

Lines changed: 0 additions & 5 deletions
This file was deleted.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
// THIS FILE SHOULD NOT BE VERSION CONTROLLED

test/fixture/nuxt.config.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ module.exports = {
2222

2323
workbox: {
2424
offlineAnalytics: true,
25+
dev: true,
2526
config: {
2627
debug: true
2728
},

0 commit comments

Comments
 (0)