Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the behavior of empty-title replacement #48

Merged
merged 1 commit into from
Apr 2, 2018
Merged

Improve the behavior of empty-title replacement #48

merged 1 commit into from
Apr 2, 2018

Conversation

ciscorn
Copy link
Contributor

@ciscorn ciscorn commented Mar 16, 2018

We shouldn't replace empty head.title with options.name when the head.titleTemplate is a function.

The head.titleTemplate function is used to generate the default title when head.title is intentionally set to be null. See this

@pi0
Copy link
Member

pi0 commented Apr 2, 2018

Thank you. I'll merge it as a fix.

@pi0 pi0 merged commit 8c3f319 into nuxt-community:master Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants