Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sort): use -1 for descending same as mongo syntax #1176

merged 1 commit into from May 30, 2022


Copy link

@farnabaz farnabaz commented May 30, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The idea is to match sort syntax with mongo db syntax. Mongodb uses 1 for ascending and -1 for descending sorts.
This PR will introduce a breaking change in sorting behavior. Former this content module used 0 for descending sort.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

netlify bot commented May 30, 2022

βœ… Deploy Preview for nuxt-content ready!

Name Link
πŸ”¨ Latest commit 8500351
πŸ” Latest deploy log
😎 Deploy Preview
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

Atinux commented May 30, 2022

Let's merge quickly since few people are using sorts for now. Can we plan a patch release today or tomorrow?

Copy link
Member Author

There is also some bug fixes in the main branch, we will plan a release for tomorrow

@farnabaz farnabaz merged commit 564b2e8 into main May 30, 2022
@farnabaz farnabaz deleted the fix/sort-order branch May 30, 2022 14:09
Copy link

enfipy commented Jul 18, 2022

Guys, please update the documentation on this one. I spent an hour figuring things out πŸ™

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants