Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(code-block): use span with \n instead of div for lines #2008

Merged
merged 2 commits into from
Apr 17, 2023
Merged

fix(code-block): use span with \n instead of div for lines #2008

merged 2 commits into from
Apr 17, 2023

Conversation

nobkd
Copy link
Contributor

@nobkd nobkd commented Apr 14, 2023 •
edited
Loading

🔗 Linked issue

#2007

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Reverts code block lines to be wrapped in <span>s.
Adds \n line breaks at the end of each line.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Apr 14, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Apr 14, 2023 •
edited
Loading

✅ Deploy Preview for nuxt-content canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 27bb459
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/643d5a481c32250008f31021

@nobkd nobkd changed the title fix(code-block): use span with line-break tags fix(code-block): use span with <br> tags for lines Apr 15, 2023
@nobkd nobkd changed the title fix(code-block): use span with <br> tags for lines fix(code-block): use span with \n instead of div for lines Apr 17, 2023
@nobkd nobkd requested a review from farnabaz April 17, 2023 13:54
farnabaz
farnabaz approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks

@farnabaz farnabaz merged commit e946c42 into nuxt:main Apr 17, 2023
@nobkd nobkd deleted the fix(code-block)/use-span-with-br-tags-for-lines branch April 17, 2023 15:33
This was referenced Apr 18, 2023
Closed
Merged
@nobkd nobkd mentioned this pull request Oct 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farnabaz farnabaz farnabaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nobkd @farnabaz