Skip to content

use router basepath in client plugin #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 9, 2020
Merged

use router basepath in client plugin #53

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a46f789
use router basepath in client plugin
chrisjung-dev May 26, 2020
f85d223
Apply wished changes
chrisjung-dev Jun 3, 2020
5975291
fix: fix linter issues
chrisjung-dev Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,17 +118,22 @@ module.exports = async function () {
dirs: database.dirs
}
})

let publicPath = this.options.build.publicPath // can be an url
let routerBasePath = this.options.router.base

/* istanbul ignore if */
if (publicPath[publicPath.length - 1] !== '/') {
publicPath += '/'
}
if (routerBasePath[routerBasePath.length - 1] === '/') {
routerBasePath = routerBasePath.slice(0, -1)
}
this.addPlugin({
fileName: 'content/plugin.client.js',
src: join(__dirname, 'templates/plugin.static.js'),
options: {
dbPath: publicPath + 'content/db.json'
// if publicPath is an URL, use public path, if not, add basepath before it
dbPath: isUrl(publicPath) ? `${publicPath}content/db.json` : `${routerBasePath}${publicPath}content/db.json`
}
})
} else {
Expand Down Expand Up @@ -156,6 +161,16 @@ module.exports = async function () {
fileName: 'content/nuxt-content.js',
src: join(__dirname, 'templates/nuxt-content.js')
})
function isUrl (string) {
try {
// quick test if the string is an URL
// eslint-disable-next-line no-new
new URL(string)
} catch (_) {
return false
}
return true
}
}

module.exports.Database = Database
Expand Down