-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ideas / Todos #3
Comments
|
I believe this is probably out of the scope of devtools. We are not making an editor but an extension for the editor. Such thing could, later on, be in a separate project such as Nuxt Admin for a web-based editor and integrate devtools. |
I wanted to explore the feeling of it 😊 , agree that it could live in admin, but such implementation is quite easy to do. |
Sure we can experience it with admin :) It is easy but not really what I would imagine to include for devtools. We might have (readonly) editor for virtual files tough in UI since it later needs to be supported for VSCode integration as well. |
Related issues about timing and performance: |
Also, regarding the VFS, i see you supported nitrojs/nitro#173 How can we access this VFS to list the files in the devtools @pi0 ? |
We have two options: Expose a rest API from nitro vfs or since we are already planning to implement external module integrations, maybe we can simply embed the Nitro |
Well I guess it would be nice if |
We can support an explicit endpoint too but do you consider there are other UI parts being introduced by nitro such as swagger UI? Extendability of devtools is unavoidable we cannot add all modules to the devtools and there is already an undergoing feature in nitro same for modules such as tailwind. If IFrame has limitations, probably it is time to consider that. The point is to decentralize. |
I won't compare both Nitro and Nuxt modules since Nitro is part of Nuxt core and listing the VFS is same as showing the But if you want to make a "Nitro" tab in the devtools that make an iframe of |
Nitro, same as Vite is an underlying framework Nuxt is using not part of the core. We are simply leveraging a shared VFS context to be in a single layer otherwise, indeed had to have two VFSs.
As mentioned, we will have many of these cases such as Vitest UI in the future that can be easily integrated into devtools with an iframe and communicate with messaging. As for POC, Nitro already provides the UI and can be integrated inside the Devtools and this method of integration is consistent with what is planned for extendability. I think fact of having a generic code editor is making it confusing to make a decision. VFS UI is not same as the admin feature we are thinking of but can definitely benefit from a shared codebase ( |
If we are going to embed iframe for each integration (like |
Surely. We can explore it as an external module for the code editor 👍🏼 (BTW vfs, while is exposed from Nitro, can probably be called "Virtual Files" as it aggregates all of them including for Nuxt. It is kinda an exceptional part. Rest of Nitro can be referred to Nitro or Server such as "Server Routes") |
Submitted by @danielroe on Discord: |
Since most of them here are implemented or have a basic version, close in favor of #20 |
(feel free to add your ideas or discuss below!)
The text was updated successfully, but these errors were encountered: