This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(nuxt): pass async-data errors through to client #8521
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
bug
Something isn't working
π° p2-nice-to-have
Priority 2: nothing is broken but it's worth addressing
labels
Oct 27, 2022
Β Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
β Deploy Preview for nuxt3-docs canceled.
|
pi0
reviewed
Oct 27, 2022
danielroe
force-pushed
the
fix/hydrate-errors
branch
from
October 27, 2022 13:35
acae3de
to
79f21bb
Compare
Finally π |
pi0
approved these changes
Nov 2, 2022
Merged
I'm very happy about this! β€οΈ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3.x
bug
Something isn't working
π° p2-nice-to-have
Priority 2: nothing is broken but it's worth addressing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves nuxt/nuxt#12885
β Type of change
π Description
This PR passes error status/message through to client side. Together with unjs/ofetch#152 and unjs/h3#213 this will enable accessing
error.statusCode
(which is useful for making decisions regarding 404s, etc.) and will pass a normalised error object through to client.There will still be some differences between client + server errors because server errors are raw and not normalised with
createError
.You can test with:
π Checklist