Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add stripe nuxt 3 module #677

Merged
merged 10 commits into from
Jul 1, 2023
Merged

chore: add stripe nuxt 3 module #677

merged 10 commits into from
Jul 1, 2023

Conversation

fuentesloic
Copy link
Contributor

@fuentesloic fuentesloic commented Jun 25, 2023

Added nuxt 3 stripe module so our community will get an easy way to integrate Stripe into their Nuxt applications.

Note: It's addressing both client and server side. It utilizes the official stripe package for server-side usage and @stripe/stripe-js for the client-side.

Applying the following will remove the nuxt 2 stripe module reference, it will be referred in the new module documentation tho.

Module can be found here: https://www.npmjs.com/package/nuxt3-stripe

@fuentesloic
Copy link
Contributor Author

cc @flozero @danielroe

@fuentesloic fuentesloic mentioned this pull request Jun 25, 2023
6 tasks
Copy link
Contributor

@flozero flozero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to create an icon in he icons folders too. Or is it already ?

@fuentesloic
Copy link
Contributor Author

You will need to create an icon in he icons folders too. Or is it already ?

it's already there: https://github.com/nuxt/modules/blob/main/icons/stripe.png

@flozero
Copy link
Contributor

flozero commented Jun 27, 2023

Top. You just need to rebase your branch with main

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you add this as a separate slug so we preserve both in the module listing? 🙏

@fuentesloic
Copy link
Contributor Author

fuentesloic commented Jun 30, 2023

Would you add this as a separate slug so we preserve both in the module listing? 🙏

@danielroe if you have time to check it again! should be good now 😇
Slug has been set with stripe-next so the existing one (stripe) and any remote link/reference can remains.

application, both on the client-side and server-side. It utilizes the official
stripe package for server-side usage and @stripe/stripe-js for the
client-side.
repo: fuentesloic/nuxt3-stripe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I'd prefer if the module name didn't specifically mention the nuxt version, if possible (https://nuxt.com/docs/guide/going-further/modules#do-not-advertize-with-a-specific-nuxt-version)

otherwise, everything is good for me 👌

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielroe make a lot of sense! fixed with 987c74f

modules/stripe-next.yml Outdated Show resolved Hide resolved
@danielroe danielroe merged commit 480d81b into nuxt:main Jul 1, 2023
@@ -5,7 +5,7 @@ description: >-
stripe package for server-side usage and @stripe/stripe-js for the
client-side.
repo: fuentesloic/nuxt-stripe
npm: @unlok-co/nuxt-stripe
npm: "@unlok-co/nuxt-stripe"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants