Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nuxt): warn in dev when useRoute is used in middleware #20050

Merged
merged 1 commit into from
Apr 3, 2023
Merged

feat(nuxt): warn in dev when useRoute is used in middleware #20050

merged 1 commit into from
Apr 3, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

#19626 (comment)

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds a warning in dev mode when using useRoute within nuxt middleware, which will almost certainly be the wrong thing to do.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested review from manniL and pi0 April 3, 2023 10:09
@danielroe danielroe self-assigned this Apr 3, 2023
@codesandbox
Copy link

codesandbox bot commented Apr 3, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe merged commit 61699f8 into main Apr 3, 2023
@danielroe danielroe deleted the feat/warn-route-mid branch April 3, 2023 10:36
@danielroe danielroe mentioned this pull request Apr 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mercs600 mercs600 mercs600 left review comments

@pi0 pi0 pi0 approved these changes

@manniL manniL Awaiting requested review from manniL

Assignees

@danielroe danielroe

Labels
3.x dx enhancement 🍰 p2-nice-to-have pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielroe @pi0 @mercs600