Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): only add/remove trailing slash for http protocols #23296

Merged
merged 349 commits into from Dec 12, 2023
Merged

fix(nuxt): only add/remove trailing slash for http protocols #23296

merged 349 commits into from Dec 12, 2023

Conversation

manniL
Copy link
Member

@manniL manniL commented Sep 19, 2023 •
edited

🔗 Linked issue

resolves #23295

Related: unjs/ufo#175, unjs/ufo#189

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

While unjs/ufo#189 is still pending, Nuxt can have a solution on it's own to avoid adding/removing slashes from provided URLs unless the http/https protocol is set.
This is important for e.g. mailto:abc@example.com links.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Sep 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@manniL manniL changed the title fix(nuxt-link): trailing slash behavior for fragment and protocol fix(link): trailing slash behavior for fragment and protocol Sep 19, 2023
@manniL manniL changed the title fix(link): trailing slash behavior for fragment and protocol fix(nuxt): trailing slash behavior for fragment and protocol Sep 19, 2023
@manniL manniL marked this pull request as draft September 19, 2023 13:11
@manniL manniL marked this pull request as ready for review September 19, 2023 13:33
@danielroe
Copy link
Member

danielroe commented Sep 19, 2023 •
edited

This looks good to me, but it seems well on the way to being merged in unjs/ufo#175, so we probably can avoid merging here.

@manniL
Copy link
Member Author

manniL commented Sep 20, 2023

@danielroe Do you think that ufo should support exactly this feature set (fragment/protocol handling like implemented) too out of the box? 🤔

@manniL
Copy link
Member Author

manniL commented Sep 20, 2023

Will adapt this PR as soon as unjs/ufo#175 lands 👍

@manniL manniL marked this pull request as draft September 20, 2023 13:07
@manniL manniL removed the request for review from lihbr September 20, 2023 13:07
danielroe and others added 12 commits December 11, 2023 23:14
@danielroe @manniL
docs: remove extraneous brace
90b91d2
@danielroe @manniL
docs: fix other issues with routeRules example
19e2606
@renovate @danielroe @manniL
chore(deps): update all non-major dependencies (main) (#23627)
e40c493 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Roe <daniel@roe.dev>
@boc-the-git @manniL
docs: fix typo (#23716)
d657c73
@danielroe @manniL
fix(nuxt): respect custom export in component transform (#23715)
1a376b8
@danielroe @manniL
feat(nuxt): prompt to autoinstall @nuxt/image when it is used (#23717)
7031e21
@renovate @danielroe @manniL
chore(deps): update dependency execa to v8 (main) (#23690)
04fe40b 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Roe <daniel@roe.dev>
@manniL
docs: update types for useFetch/useAsyncData (#23730)
f356142
@DamianGlowala @manniL
chore: add description field for packages (#23734)
7ebb85e
@danielroe @manniL
ci: only dedupe dependencies if they affect bundle size (#23736)
c0cb471
@renovate @danielroe @manniL
chore(deps): update all non-major dependencies (main) (#23718)
c300f96 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Roe <daniel@roe.dev>
@danielroe @manniL
docs: add info about <NuxtImg> and <NuxtPicture> (#23741)
de67988
Atinux and others added 19 commits December 11, 2023 23:14
@Atinux @manniL
docs(commands): add tunnel option
91447ee
@renovate @manniL
chore(deps): update all non-major dependencies (main) (#24616)
d4511d4 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @manniL
chore(deps): update actions/stale action to v9 (main) (#24636)
54376c1 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @manniL
chore(deps): update all non-major dependencies (main) (#24628)
3446e5e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@gjssss @manniL
docs: add file name to code block (#24620)
feb20d0
@Atinux @manniL
docs: remove linking to nuxt-themes org
3d85f9a
@Atinux @manniL
chore: update markdownlintignore
888779c
@phojie @manniL
docs: update yarn -o option to --open (#24644)
b98e5d7
@danielroe @manniL
fix(nuxt): merge and apply layer hooks (#24639)
5fadb8e
@renovate @danielroe @manniL
chore(deps): update all non-major dependencies (main) (#24645)
808cc37 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Roe <daniel@roe.dev>
@danielroe @manniL
docs: add alt text for roadmap img tags
6b6e789
@renovate @danielroe @manniL
chore(deps): update all non-major dependencies (main) (#24660)
1e6338e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Roe <daniel@roe.dev>
@idorenyinudoh @manniL
docs: add missing props for <NuxtPage> (#24675)
6a45266
@danielroe @manniL
chore: update vitest dependencies (#24659)
34570d9
@renovate @manniL
chore(deps): pin devdependency @vue/test-utils to 2.4.3 (main) (#24695)
5dc1a1d 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @manniL
chore(deps): update dependency esbuild to ^0.19.9 (main) (#24668)
9378166 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @manniL
chore(deps): update vitest to v1.0.4 (main) (#24696)
d21bee4 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@manniL
feat(nuxt): add path to error.data when throwing 404 errors (#24674)
5fbc954
@manniL
chore: update based on latest ufo
4dcaa2a
@nuxt-studio Nuxt Studio
Copy link

nuxt-studio bot commented Dec 11, 2023

✅ Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio ↗︎ View Live Preview 4dcaa2a

@manniL manniL changed the title fix(nuxt): trailing slash behavior for fragment and protocol fix(nuxt): trailing slash behavior for non-http based protocol Dec 11, 2023
@manniL manniL marked this pull request as ready for review December 11, 2023 22:23
@danielroe danielroe changed the title fix(nuxt): trailing slash behavior for non-http based protocol fix(nuxt): do not add/remove trailing slash for non-http protocols Dec 12, 2023
@danielroe danielroe changed the title fix(nuxt): do not add/remove trailing slash for non-http protocols fix(nuxt): only add/remove trailing slash for http protocols Dec 12, 2023
@danielroe danielroe merged commit 5d0e7e9 into main Dec 12, 2023
38 checks passed
@danielroe danielroe deleted the fix/nuxt-trailing-slash branch December 12, 2023 12:52
@github-actions github-actions bot mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x bug 🔨 p3-minor-bug pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trailing Slash behavior for fragment links or various protocols (e.g. mailto:)