-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
docs: fix more links #33265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix more links #33265
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughDocumentation-only updates across many markdown files: numerous in-page anchor links were replaced with absolute documentation paths or had minor URL formatting changes. Minor wording edits were made in the View Transitions doc (consolidated demo link, reworded enabling sentence). Additionally, lychee.toml was modified: base renamed to base_url (with trailing slash), accepted HTTP status codes expanded, fragment checking enabled, redirect and retry/timeouts configured, user agent set, and one URL added to the exclude list. No code, API signatures, or runtime behaviour changes were introduced. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (31)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
docs/2.guide/1.concepts/7.esm.md (1)
35-35
: Link tweak looks good; tiny grammar polish optionalThe trailing-slash fix is fine. Optional: add “the” for smoother phrasing.
Apply this diff if you agree:
-However, there are some key differences with actual spec; here's [a helpful explainer](https://hacks.mozilla.org/2018/03/es-modules-a-cartoon-deep-dive/). +However, there are some key differences with the actual spec; here's [a helpful explainer](https://hacks.mozilla.org/2018/03/es-modules-a-cartoon-deep-dive/).docs/1.getting-started/09.transitions.md (1)
418-418
: Consolidated demo link LGTMPointing readers straight to StackBlitz is clearer and reduces link churn.
Optionally consider a read‑only/embedded view for a nicer first‑click experience (StackBlitz supports embed parameters), but fine to keep as-is.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/1.getting-started/09.transitions.md
(1 hunks)docs/2.guide/1.concepts/7.esm.md
(1 hunks)
You can check a demo [on StackBlitz](https://stackblitz.com/edit/nuxt-view-transitions). | ||
|
||
The Nuxt integration is under active development, but can be enabled with the `experimental.viewTransition` option in your configuration file: | ||
The Nuxt integration can be enabled with the `experimental.viewTransition` option in your configuration file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Wording change LGTM; confirm intent to drop “under active development”
Given this is still behind experimental.viewTransition
, is it intentional to remove the development-status note for 4.x docs?
If you want, I can run a quick link check over the touched docs to ensure no regressions.
🏁 Script executed:
#!/bin/bash
# Requires Node.js
npx -y markdown-link-check docs/1.getting-started/09.transitions.md -q
npx -y markdown-link-check docs/2.guide/1.concepts/7.esm.md -q
Length of output: 1119
Confirm removal of "under active development" and fix broken docs links
Wording change LGTM; confirm this is intentional while the feature remains behind experimental.viewTransition
.
- Dead links found in docs/1.getting-started/09.transitions.md (7):
- /docs/4.x/guide/directory-structure/app/pages — 400
- /docs/4.x/getting-started/transitions#layout-transitions — 400
- /docs/4.x/guide/directory-structure/app — 400
- /docs/4.x/api/utils/define-page-meta — 400
- /docs/4.x/guide/directory-structure/app/layouts — 400
- https://gsap.com — 403
- /docs/4.x/guide/directory-structure/app/middleware — 400
Fix or update those links (and replace/remove the gsap link) before merging.
🤖 Prompt for AI Agents
In docs/1.getting-started/09.transitions.md around line 420, confirm that
removing "under active development" is intentional while the feature remains
behind experimental.viewTransition, and fix the seven broken links: replace the
/docs/4.x/... absolute paths with the correct current-docs paths or relative
anchors (or update them to /docs/getting-started/... or the matching v4 routes
used by this repo), correct the transitions anchor to the proper section
(layout-transitions) URL, and update app/pages, app, define-page-meta,
app/layouts, and app/middleware links to their valid doc locations; remove or
replace the https://gsap.com link with an allowed, reachable resource (or a
local note) and verify all updated URLs return 200 before merging.
CodSpeed Performance ReportMerging #33265 will not alter performanceComparing Summary
Footnotes |
🔗 Linked issue
📚 Description
more fixes