feat: add useScriptVimeo + Vimeo component #8
Conversation
|
This is looking great! Thanks for your work. I'd like to see this get merged, did you have anything else on your end you wanted to do? |
src/runtime/components/Vimeo.vue
Outdated
| const id = useId(); | ||
| const status: Ref<string> = ref(null); | ||
|
|
||
| const { Player } = useScriptVimeo(); |
There was a problem hiding this comment.
It would be cool to see the script load in lazily based on whether the component is entering the viewport.
This can be done with the trigger option.
There was a problem hiding this comment.
Great idea, should I add lazy prop to the component which is true by default?
No problem 🙂 I'll need to fix those minor issues because it's still work in progress, I just wanted to check if you agree with having "wrapper" components for some scripts. |
|
|
||
| let player; | ||
|
|
||
| if (!props.lazy) $script.then(init); |
There was a problem hiding this comment.
really cool 👏 good call on the prop
maybe we could add a prop for the rootMargin with a default of ~50px, it should help minimise the CLS
There was a problem hiding this comment.
👍 sure, I'll add that
|
Thanks again for your work on this, it's a great addition. I'm going to merge it in, it may need some slight tweaks once I play around with it. Will also need docs but I need to figure out how those are going to work. |
WIP - showcase for Vimeo component