Fix testing of fork-ts-checker-webpack-plugin v4 #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin's apply function doesn't pass schema validation. Schema expects an instance of Function while `plugin.apply instanceof Function` return `false`. The issue has to do with how the new version of fork-ts-checker-webpack-plugin is compiled. Previously it targeted es6 and code was compiled into classes where methods pass the `instanceof Function` check while currently it's compiled to es5 target and methods are added through prototype chain and no longer pass `instanceof Function` check. This problem only manifests itself when combined with jest mocking the function (bug jestjs/jest#6329 which is a duplicate of unsolved one). Fix by mocking the creating a fresh mock implementation instead of augmenting original plugin. Resolves #273
1 task
kevinmarrec
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes renovate deps update and a fix for tests.