fix: avoid referring to complex types in props #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to workaround the compatibility with nuxt-component-meta fix nuxtlabs/studio-app#289
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for nuxthq-ui canceled.
|
| @@ -47,7 +47,7 @@ const props = defineProps({ | |||
| default: () => $ui.contextMenu.transition | |||
| }, | |||
| popperOptions: { | |||
| type: Object as PropType<PopperOptions>, | |||
| type: Object, | |||
There was a problem hiding this comment.
Why remove the PopperOptions type here? It's also defined in Dropdown, SelectCustom, Popover and Tooltip. Should we remove them all?
There was a problem hiding this comment.
Yeah it's a non-issue. Reverted
benjamincanac
approved these changes
Dec 17, 2022
benjamincanac
added a commit
that referenced
this pull request
Jul 24, 2024
#123) Co-authored-by: Benjamin Canac <canacb1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to workaround the compatibility with nuxt-component-meta
Resolves nuxtlabs/studio-app#289
This is because
nuxt-component-metaexpanded the type entirely in the schema, creating 150MB of objects that have been duplicated a few times, causing the memory overflow.The root fix should be done on the
nuxt-component-metaside, but it takes some research. Workaround here to make it non-blocking.