-
Notifications
You must be signed in to change notification settings - Fork 244
feat: better template support #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
// TODO: Still failing :( Child template won't be applied if child has no content as well | ||
|
||
it('properly uses meta templates with one-level-deep nested children template', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is still a problem 😞
@manniL Thanks for working on this! 🙂 |
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
=========================================
+ Coverage 35.29% 40.3% +5.01%
=========================================
Files 18 18
Lines 255 263 +8
=========================================
+ Hits 90 106 +16
+ Misses 165 157 -8
Continue to review full report at Codecov.
|
Working on multi nested child with templates to make sure it works perfectly |
Well, at the moment it supports only one child with template, it's fine and more children should not happen in usage. Will see if people need this. |
Works like a charm :) Thank you so much! 👍 💯 |
Hey @manniL can I get a use case example of this? Because currently the documentation seems to reflect the older version of how to use this. |
@Sylk Please check the tests for it for now. Don't have an example ready yet |
I'm fairly new to this, so reading them helped a bit. But to follow up, do I need to apply the following to every instance of
|
@Sylk I've created the example from the tests As you see, The child component |
Addresses issues left over in #202, especially that templates in the parent component are applied with child values.
Scenarios: