Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-id] Translate guides/features #659

Merged
merged 7 commits into from
Sep 21, 2020
Merged

[docs-id] Translate guides/features #659

merged 7 commits into from
Sep 21, 2020

Conversation

danilhendrasr
Copy link
Contributor

@danilhendrasr danilhendrasr commented Sep 5, 2020 •
edited
Loading

Translation contribution for issue #549

📝 guides -> features:

  • live-preview.md
  • meta-tags-seo.md

@danilhendrasr danilhendrasr marked this pull request as ready for review September 5, 2020 14:04
@danilhendrasr
Copy link
Contributor Author

Need review, mas @febrihidayan @jefrydco

@febrihidayan
Copy link
Collaborator

@danilhendras cuma kata Anda yang banyak diperbaiki, mas

@danilhendrasr
Copy link
Contributor Author

@danilhendras cuma kata Anda yang banyak diperbaiki, mas

Maaf mas @febrihidayan , saya kurang paham maksudnya. Mungkin masnya bisa kasih komentar atau review di berkasnya saja biar saya lebih jelas mana yang perlu dipertimbangkan lagi.

@febrihidayan
Copy link
Collaborator

@danilhendras cuma kata Anda yang banyak diperbaiki, mas

Maaf mas @febrihidayan , saya kurang paham maksudnya. Mungkin masnya bisa kasih komentar atau review di berkasnya saja biar saya lebih jelas mana yang perlu dipertimbangkan lagi.

Maksud saya, mas. Kata anda banyak yang harus diperbaiki katanya menjadi Anda, harus di awali huruf besar

@danilhendrasr
Copy link
Contributor Author

Maksud saya, mas. Kata anda banyak yang harus diperbaiki katanya menjadi Anda, harus di awali huruf besar

Resolved with the latest commit

@danilhendrasr
Copy link
Contributor Author

Saya rasa sudah tidak ada yang perlu diperbaiki lagi.
Butuh approve-nya mas @febrihidayan :)

febrihidayan
febrihidayan approved these changes Sep 8, 2020
View reviewed changes
content/id/guides/features/meta-tags-seo.md Outdated Show resolved Hide resolved
content/id/guides/features/meta-tags-seo.md Outdated Show resolved Hide resolved
content/id/guides/features/meta-tags-seo.md Outdated Show resolved Hide resolved
@danilhendrasr
Copy link
Contributor Author

Kindly re-review this PR pls :) @jefrydco @febrihidayan

@debs-obrien
Copy link
Contributor

Thanks guys 💪

@debs-obrien debs-obrien merged commit 7f7d8dd into nuxt:master Sep 21, 2020
@danilhendrasr danilhendrasr deleted the 549_translate-guides/features branch September 21, 2020 16:19
@febrihidayan febrihidayan mentioned this pull request Feb 13, 2021
Open
94 tasks
pi0 pushed a commit that referenced this pull request Jul 8, 2021
@danilhendrasr
[docs-id] Translate guides/features (#659)
8cfc97d 
* Copy english version files

* live-preview.md done

* meta-tags-seo.md done

* Fixed minor writing errors

* Fix word 'anda' to 'Anda'

* Fix minor writing errors

* Minor changes
imgbot bot pushed a commit that referenced this pull request Jan 10, 2023
@danilhendrasr @ImgBotApp
[docs-id] Translate guides/features (#659)
f05b169 
* Copy english version files

* live-preview.md done

* meta-tags-seo.md done

* Fixed minor writing errors

* Fix word 'anda' to 'Anda'

* Fix minor writing errors

* Minor changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefrydco jefrydco jefrydco approved these changes

@febrihidayan febrihidayan febrihidayan approved these changes

Assignees
No one assigned
Labels
indonesia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danilhendrasr @febrihidayan @debs-obrien @jefrydco