[RELEASE] MRC v24.03.00 #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #419 from mdemoret-nv/branch-24.03-merge-23.11
Updates MRC to use `dependencies.yaml` for the source of truth for environment files, and adds a pre-commit hook to ensure the environment files get generated before commit. Also adds the pre-commit hook as a check in CI to ensure we catch missed changes. Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - David Gardner (https://github.com/dagardner-nv) - Michael Demoret (https://github.com/mdemoret-nv) URL: #416
Adds falke8, yapf, and isort pre-commit hooks. Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #420
…425) Removes the deprecated python settings in favor of the options recommended in https://github.com/microsoft/vscode-python/wiki/Migration-to-Python-Tools-Extensions Authors: - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Devin Robison (https://github.com/drobison00) URL: #425
…426) * Adds a new `has_skip_ci_label` output to the `prepare` job. * Skips the rest of the pipeline when true Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #426
* Prevent `libmrc_pymrc.so` from being installed into python's site-packages dir, as this lib is already present in the lib dir. * Fixes permissions issue where the conda env was owned by `root:root`, simply ensuring the env retains the `conda` group permission wasn't sufficient as `cmake` attempts to modify exiting dirs (https://gitlab.kitware.com/cmake/cmake/-/issues/10978), and running `chmod -R` after the fact is too slow. Closes #428 Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #429
This PR fixes an issue where some libraries were using `${PROJECT_NAME}-core-exports` and others were using `${PROJECT_NAME}-exports`. Since there is no need for multiple export sets anymore, this updates all exports to be `${PROJECT_NAME}-exports`
Requires nv-morpheus/utilities#61 to be merged first
Authors:
- Michael Demoret (https://github.com/mdemoret-nv)
- David Gardner (https://github.com/dagardner-nv)
Approvers:
- David Gardner (https://github.com/dagardner-nv)
URL: #427
Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #433
Closes #435 Closes #424 Closes #423 Closes #422 Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #436
per request from ops Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Christopher Harris (https://github.com/cwharris) URL: #442
Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #444
This PR enables the ForwardMerger [ops-bot](https://github.com/rapidsai/ops-bot) plugin. Authors: - Jake Awe (https://github.com/AyodeAwe) Approvers: - Christopher Harris (https://github.com/cwharris) URL: #446
Add the io_scheduler from libcoro, rename to IoScheduler, use standard code styles, and adjust implementation to support MRC's other libcoro port details. Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #448
…am nodes (#449) 1. Adds a new C++ type `RoundRobinRouterTypeless` which is very similar to `BroadcastTypeless` except it only pushes values to one of the downstream connections instead of copying 2. Adds a new Python type `RoundRobinRouter` which allows using the `RoundRobinRouterTypeless` from python 3. Adds a C++ test to confirm connectivity 4. Adds Python tests to verify output Authors: - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Devin Robison (https://github.com/drobison00) URL: #449
…eturning null (#451) * Currently when `cast_from_pyobject` encounters an unsupported type it returns a json null. * Updates the method to throw a `pybind11::type_error`, matching the `TypeError` exception raised by the Python std `json.dumps` method. * Add `get_py_type_name` helper method * Breaking behavior change Closes #450 Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #451
When running an instance of the `AsyncioRunnable` class, it populates the output with: ``` I20240313 16:41:26.300143 3296734 asyncio_runnable.hpp:246] AsyncioRunnable::run() > Creating new event loop I20240313 16:41:26.300436 3296734 asyncio_runnable.hpp:259] AsyncioRunnable::run() > Calling run_until_complete() on main_task() ``` This PR changes that to a `DVLOG(10)` since this information is more tracing than actually informative. Authors: - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Christopher Harris (https://github.com/cwharris) - David Gardner (https://github.com/dagardner-nv) URL: #456
…waiting for timeouts (#453) Adds a manually driven TestScheduler that can fast-forward through delayed coroutines. Required for nv-morpheus/Morpheus#1548 Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #453
|
/ok to test |
Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Christopher Harris (https://github.com/cwharris) URL: #460
Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #467
Adds maximum simultaneous tasks support to `TaskContainer` by only starting new tasks if the number of currently executing tasks is less than the maximum number of simultaneous tasks and starting new tasks as older tasks shut down. this eliminates the need for external semaphores or ticketing systems. Authors: - Christopher Harris (https://github.com/cwharris) - David Gardner (https://github.com/dagardner-nv) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #464
…ranch-*` and `main` to succeed
mdemoret-nv
approved these changes
Apr 8, 2024
|
/ok to test |
|
/ok to test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
==========================================
- Coverage 74.03% 73.99% -0.05%
==========================================
Files 394 402 +8
Lines 13955 14411 +456
Branches 1053 1133 +80
==========================================
+ Hits 10332 10663 +331
- Misses 3623 3748 +125
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❄️ Code freeze for
branch-24.03andv24.03releaseWhat does this mean?
Only critical/hotfix level issues should be merged into
branch-24.03until release (merging of this PR).All other development PRs should be retargeted towards the next release branch:
branch-24.06.What is the purpose of this PR?
branch-24.03intomainfor the release