-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define a Python source which receives a reference to a subscriber #496
Define a Python source which receives a reference to a subscriber #496
Conversation
…fine a class SubscriberFuncWrapper rather than just a lambda. The reason is that python objects captured by the lambda need to be destroyed while the gil is held, which causes a problem if the lambda is destroyed unexpectedly.
/merge |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## branch-24.10 #496 +/- ##
================================================
+ Coverage 74.06% 74.09% +0.03%
================================================
Files 403 403
Lines 14403 14424 +21
Branches 1132 1134 +2
================================================
+ Hits 10667 10688 +21
Misses 3736 3736
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Description
SubscriberFuncWrapper
for Python sources rather than just a lambda. The reason is that python objects captured by the lambda need to be destroyed while the gil is held, which causes a problem if the lambda is destroyed unexpectedly.conftest.py
to set the loglevel toDEBUG
if theGLOG_v
environment variable is defined.Checklist