Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LOG(WARNING) to VLOG(1) when no GPUs are detected #497

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Sep 5, 2024

  • Since CPU-only mode will become a supported feature we want to avoid unnecessary warnings.

Relates to nv-morpheus/Morpheus#1851

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

…unning in CPU-only mode will become a supported feature
@dagardner-nv dagardner-nv added improvement Improvement to existing functionality non-breaking Non-breaking change labels Sep 5, 2024
@dagardner-nv dagardner-nv self-assigned this Sep 5, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner September 5, 2024 22:59
cpp/mrc/src/internal/system/device_info.cpp Outdated Show resolved Hide resolved
@dagardner-nv dagardner-nv changed the title Change LOG(WARNING) to DVLOG(1) when no GPUs are detected Change LOG(WARNING) to VLOG(1) when no GPUs are detected Sep 11, 2024
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ccbcd76 into nv-morpheus:branch-24.10 Sep 11, 2024
17 checks passed
@dagardner-nv dagardner-nv deleted the david-silence-cpu-only-warning branch September 11, 2024 22:41
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.08%. Comparing base (ca8a73f) to head (b64edbd).
Report is 2 commits behind head on branch-24.10.

Files with missing lines Patch % Lines
cpp/mrc/src/internal/system/device_info.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.10     #497      +/-   ##
================================================
+ Coverage         74.06%   74.08%   +0.02%     
================================================
  Files               403      403              
  Lines             14403    14403              
  Branches           1132     1132              
================================================
+ Hits              10667    10671       +4     
+ Misses             3736     3732       -4     
Flag Coverage Δ
cpp 70.83% <0.00%> (+0.02%) ⬆️
py 41.82% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cpp/mrc/src/internal/system/device_info.cpp 56.09% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca8a73f...b64edbd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants