Skip to content

Commit

Permalink
unchecking all NVDA modifier keys in the keyboard settings dialog sho…
Browse files Browse the repository at this point in the history
…uld give an error. Exact patch re #2871
  • Loading branch information
heikofolkerts authored and michaelDCurran committed Oct 1, 2013
1 parent 1edd033 commit 1406623
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
9 changes: 9 additions & 0 deletions source/gui/settingsDialogs.py
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,15 @@ def postInit(self):
self.kbdList.SetFocus()

def onOk(self,evt):
# #2871: check wether at least one key is the nvda key.
if self.capsAsNVDAModifierCheckBox.IsChecked() == False and self.numpadInsertAsNVDAModifierCheckBox.IsChecked() == False and self.extendedInsertAsNVDAModifierCheckBox.IsChecked() == False:
log.error("Error when setting the key to use as NVDA key.")
gui.messageBox(
# Translators: Message to report wrong configuration of the NVDA key
_("At least one key must be used as NVDA key. Without that you won't be able to access the NVDA dialogs any more."),
# Translators: The title of the message box
_("Error"), wx.OK|wx.ICON_ERROR,self)
return
layout=self.kbdNames[self.kbdList.GetSelection()]
config.conf['keyboard']['keyboardLayout']=layout
config.conf["keyboard"]["useCapsLockAsNVDAModifierKey"]=self.capsAsNVDAModifierCheckBox.IsChecked()
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/userGuide.t2t
Original file line number Diff line number Diff line change
Expand Up @@ -781,6 +781,7 @@ If this checkbox is checked, the extended insert key (usually found above the ar

==== Use numpad insert as an NVDA modifier key ====
If this checkbox is checked, the insert key on the number pad can be used as an NVDA modifier key.
If you uncheck all three check boxes for the NVDA modifier key the dialog will display an error message when you try to close it with OK. This is because without any key set as NVDA modifier key you won't be able to control NVDA via the keyboard.

%kc:setting
==== Speak Typed Characters ====
Expand Down

0 comments on commit 1406623

Please sign in to comment.