Skip to content

Commit

Permalink
revert 16463 and 16501 (#16519)
Browse files Browse the repository at this point in the history
Reverts #16463 and #16501

Issues fixed
Issues reopened
Reopens #16456

Reason for revert
complexity

Can this PR be reimplemented? If so, what is required for the next attempt
at least execution of scrollToCursorOrSelection in _doNewObject
  • Loading branch information
burmancomp committed May 10, 2024
1 parent 2fb42d5 commit 2d86502
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions source/braille.py
Original file line number Diff line number Diff line change
Expand Up @@ -2560,9 +2560,8 @@ def _doNewObject(self, regions):
self.mainBuffer.update()
# Last region should receive focus.
self.mainBuffer.focus(region)
if isinstance(region, TextInfoRegion):
self.scrollToCursorOrSelection(region)
elif self.buffer is self.mainBuffer:
self.scrollToCursorOrSelection(region)
if self.buffer is self.mainBuffer:
self.update()
elif self.buffer is self.messageBuffer and keyboardHandler.keyCounter>self._keyCountForLastMessage:
self._dismissMessage()
Expand Down Expand Up @@ -2616,10 +2615,8 @@ def _handlePendingUpdate(self):
self.mainBuffer.update()
self.mainBuffer.restoreWindow()
if scrollTo is not None:
if self.buffer is self.messageBuffer:
self._dismissMessage(shouldUpdate=False)
self.scrollToCursorOrSelection(scrollTo)
elif self.buffer is self.mainBuffer:
if self.buffer is self.mainBuffer:
self.update()
elif (
self.buffer is self.messageBuffer
Expand Down

0 comments on commit 2d86502

Please sign in to comment.