-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant braille.BrailleHandler.update executions #16463
Conversation
This looks reasonable at first sight, though I"m a bit worried about unexpected side effects. This definitely needs a merge early in a release cycle, therefore I'll add the appropriate label for that. |
This pr causes an issue where braille messages aren't properly dismissed when braille changes while viewing them. |
…access#16463)" This reverts commit 29f4c5c.
…illeHandler.update executions #16501 fixes #16463 Summary of the issue: Fix for issue of #16463 where braille message was not dismissed. Description of user facing changes Braille message should be dismissed when moving cursor. Description of development approach if buffer is message buffer BrailleHandler._dismissMessage is executed before BrailleHandler.scrollToCursorOrSelection.
…6463) fixes nvaccess#16456 Summary of the issue: In braille.BrailleHandler._handlePendingUpdate and braille.BrailleHandler._doNewObject functions scrollTocursororSelection function is called. scrollToCursorOrSelection calls scrollTo which in turns calls braille.BrailleHandler.update. Both _handlePendingUpdate and _doNewObject call braille.BrailleHandler.update after calling scrollToCursorOrSelection. Description of user facing changes There should be less "Braille window dots" log lines when log level is debug. Maybe some minor effect on performance. Description of development approach Minor modifications of _handlePendingUpdate and _doNewObject functions.
…illeHandler.update executions nvaccess#16501 fixes nvaccess#16463 Summary of the issue: Fix for issue of nvaccess#16463 where braille message was not dismissed. Description of user facing changes Braille message should be dismissed when moving cursor. Description of development approach if buffer is message buffer BrailleHandler._dismissMessage is executed before BrailleHandler.scrollToCursorOrSelection.
Reverts nvaccess#16463 and nvaccess#16501 Issues fixed Issues reopened Reopens nvaccess#16456 Reason for revert complexity Can this PR be reimplemented? If so, what is required for the next attempt at least execution of scrollToCursorOrSelection in _doNewObject
Link to issue number:
fixes #16456
Summary of the issue:
In
braille.BrailleHandler._handlePendingUpdate
andbraille.BrailleHandler._doNewObject
functionsscrollTocursororSelection
function is called.scrollToCursorOrSelection
callsscrollTo
which in turns callsbraille.BrailleHandler.update
. Both_handlePendingUpdate
and_doNewObject
callbraille.BrailleHandler.update
after callingscrollToCursorOrSelection
.Description of user facing changes
There should be less "Braille window dots" log lines when log level is debug. Maybe some minor effect on performance.
Description of development approach
Minor modifications of
_handlePendingUpdate
and_doNewObject
functions.Testing strategy:
Local testing in daily use
Known issues with pull request:
none at this moment
Code Review Checklist: