Fix for dismiss braille message issue of remove redundant braille.BrailleHandler.update executions #16501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanbudd
approved these changes
May 8, 2024
5 tasks
burmancomp
added a commit
to burmancomp/nvda
that referenced
this pull request
May 10, 2024
…ille.BrailleHandler.update executions nvaccess#16501"
seanbudd
pushed a commit
that referenced
this pull request
May 10, 2024
XLTechie
pushed a commit
to XLTechie/xlnvda
that referenced
this pull request
May 10, 2024
…illeHandler.update executions nvaccess#16501 fixes nvaccess#16463 Summary of the issue: Fix for issue of nvaccess#16463 where braille message was not dismissed. Description of user facing changes Braille message should be dismissed when moving cursor. Description of development approach if buffer is message buffer BrailleHandler._dismissMessage is executed before BrailleHandler.scrollToCursorOrSelection.
XLTechie
pushed a commit
to XLTechie/xlnvda
that referenced
this pull request
May 10, 2024
Reverts nvaccess#16463 and nvaccess#16501 Issues fixed Issues reopened Reopens nvaccess#16456 Reason for revert complexity Can this PR be reimplemented? If so, what is required for the next attempt at least execution of scrollToCursorOrSelection in _doNewObject
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fixes #16463
Summary of the issue:
Fix for issue of #16463
where braille message was not dismissed.
Description of user facing changes
Braille message should be dismissed when moving cursor.
Description of development approach
if buffer is message buffer
BrailleHandler._dismissMessageis executed beforeBrailleHandler.scrollToCursorOrSelection.Testing strategy:
message dismissed
Known issues with pull request:
none at this moment
Code Review Checklist: