Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows 10 20H1/Windows Search: add SearchApp as an alias for SearchUI #10350

Closed
josephsl opened this issue Oct 8, 2019 · 0 comments · Fixed by #10351
Closed

Windows 10 20H1/Windows Search: add SearchApp as an alias for SearchUI #10350

josephsl opened this issue Oct 8, 2019 · 0 comments · Fixed by #10351
Milestone
2019.3

Comments

@josephsl
Copy link
Collaborator

josephsl commented Oct 8, 2019

Hi,

This issue should have been brought up in the first place... I was hoping to delay it until February but looks like it must be done now:

Is your feature request related to a problem? Please describe.

In Windows 10 20H1 (particularly after build 18963), Start Menu/Windows Search executable has been renamed form SearchUI to SearchApp. Because of this, pull requests dealing with Windows Search (such as #10329 and #10341) will fail on 20H1 builds.

Describe the solution you'd like

Add searchapp.py as an alias for searchui app module.

Describe alternatives you've considered

Leave it as is.

Additional context

Applicable in 20H1 and later - 1909 still ships with SearchUI.exe. As this affects current and future issues, it should be included as soon as possible.

Thanks.
josephsl added a commit to josephsl/nvda that referenced this issue Oct 8, 2019
@josephsl
Windows Search: renamed from searchui to searchapp in build 18965. Re n…
dd26cff 
…vaccess#10350.

Several Windows Search features will not work in Windows 10 build 18965 and later becasue executable has been renamed from searchui to searchapp. Therefore add an alias app module for SearchApp.exe that imports everything from searchui app module.
@josephsl josephsl mentioned this issue Oct 8, 2019
Merged
michaelDCurran pushed a commit that referenced this issue Oct 9, 2019
@josephsl @michaelDCurran
Windows Search: renamed from searchui to searchapp in build 18965. Re #…
afe2628 
…10350. (#10351)

Several Windows Search features will not work in Windows 10 build 18965 and later becasue executable has been renamed from searchui to searchapp. Therefore add an alias app module for SearchApp.exe that imports everything from searchui app module.
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2019.3
Development

Successfully merging a pull request may close this issue.

Windows Search: renamed from searchui to searchapp in build 18965 josephsl/nvda
2 participants
@josephsl @nvaccessAuto