Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse navigation in Firefox: Speech a portion of text aloud or do not speech text in certain paragraphs #15990

Closed
hwf1324 opened this issue Dec 31, 2023 · 7 comments · Fixed by #16912
Assignees
Labels
feature/mouse-tracking p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.

Comments

@hwf1324
Copy link
Contributor

hwf1324 commented Dec 31, 2023

Note: This issue is different from other mouse tracking issues.
To fully reproduce the issue, please open the original webpage.
Will text unit resolution left at the default "paragraph".

Steps to reproduce:

  1. Open the link in Firefox:

nvaccess/nvda-misc-deps#30 (comment)

  1. Move the cursor to the paragraph using the mouse

As such text2tags doesn't have default rules for this. To retain our custom anchors, I added rules for a common markdown extended syntax. This is supported by the python markdown legacy attributes extension.
Similarly we use a custom syntax for autogenerating the Table of contents.

  1. Then move the mouse cursor to the paragraph

Similarly we use a custom syntax for autogenerating the Table of contents.

Actual behavior:

In step 2, the speech output is:

As such text2tags doesn't have default rules for this. To retain our custom anchors, I added rules f

Step 3, no speech output

Note that this problem does not only occur when there are links in a paragraph.

Expected behavior:

Should be consistent with Chrome and Edge, speech the text under the mouse cursor

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

All

NVDA version:

2023.3 to latest alpha

Windows version:

Windows 11
Version 22H2 (OS Build 22621.2861)

Name and version of other software in use when reproducing the issue:

Firefox
121.0 (64-bit)

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

same

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes

@hwf1324
Copy link
Contributor Author

hwf1324 commented Dec 31, 2023

Open https://plantuml.com/en/class-diagram

After the second paragraph of the article, the "text" under the mouse is not read aloud, or is misplaced.

@hwf1324
Copy link
Contributor Author

hwf1324 commented Dec 31, 2023

Cc: @jcsteh

I'm not sure if this is a Firefox issue, the Firefox accessibility tree looks correct.

The narrator doesn't have this issue either.

Incidentally, when using the Accessibility tab's Select Accessible Objects in Web Pages feature, the mouse cursor does not seem to be able to accurately select accessible objects. It seems to have to go some distance below the accessible object before it can highlight it.
Correction, this is because I inadvertently changed the zoom of the page

@seanbudd seanbudd added feature/mouse-tracking p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. blocked/needs-technical-investigation Issue is blocked. A technical investigation is required to progress the issue. labels Jan 1, 2024
@jcsteh
Copy link
Contributor

jcsteh commented Jul 25, 2024

I have a patch locally which fixes this. I'll submit a PR when I get some time.

@jcsteh jcsteh self-assigned this Jul 25, 2024
@jcsteh jcsteh removed the blocked/needs-technical-investigation Issue is blocked. A technical investigation is required to progress the issue. label Jul 25, 2024
@hwf1324
Copy link
Contributor Author

hwf1324 commented Jul 25, 2024

Thank you very much for your work.

@MoubinShiraz
Copy link

Hi @hwf1324 .
It seems that they have fixed the BUG. However, when I open this again https://codepen.io/Moubin-Shiraz/pen/LYKRpJB/ , the BUG still exists in my system "Windows 11". Can you please confirm that is it only on my side or you are also facing the same.
If you are not facing the same issue again. Please let me know how should I get those changes in NVDA desktop App in my system?

cc: @jcsteh

@seanbudd
Copy link
Member

@MoubinShiraz - I'm not sure how you have tested this, are you testing with the latest alpha build? https://www.nvaccess.org/files/nvda/snapshots/

This code won't be released to NVDA stable until 2024.4 is released

@hwf1324
Copy link
Contributor Author

hwf1324 commented Jul 29, 2024

@MoubinShiraz
I confirm that this issue is fixed in NVDA version: alpha-33085,f05f1c8f (2024.4.0.33085).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/mouse-tracking p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
4 participants