Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently used Danish braille tables no longer exist #4986

Closed
nvaccessAuto opened this Issue Mar 20, 2015 · 8 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto
Copy link

nvaccessAuto commented Mar 20, 2015

Reported by dkager on 2015-03-20 13:53
The table definitions in braille.py contain two Danish tables:

  • da-dk-g1.utb (grade 1)
  • da-dk-g2.ctb (grade 2)

Neither of these tables is available in the liblouis submodule at version 2.6.0. If the user selects these tables in a fresh copy of NVDA 2015.1, there is no braille output. The likely replacements are:

  • da-dk-g16.utb (grade 1)
  • da-dk-g26.ctb (grade 2)

But it might be desirable to also include the 8-dot variants. As I'm not Danish I can't evaluate the changes between the old tables and the new ones.

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Mar 20, 2015

Comment 1 by leonarddr on 2015-03-20 14:00
How are does tables in current 2.6.2? Since the upgrade to liblouis 2.7.0 (as proposed in #4777] comment 7) won't be there in time for 2015.2, I believe that this bug should be fixed regardless of the progress in #4777.

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Mar 20, 2015

Comment 2 by nvdakor on 2015-03-20 14:00
Hi,
Let me ask the LibLouis mailing list as to which tables should be used, and if so, I'll update the braille table module.
Cheers,
Joseph

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Mar 20, 2015

Comment 3 by dkager (in reply to comment 1) on 2015-03-20 14:11
Replying to leonarddr:

How are does tables in current 2.6.2? Since the upgrade to liblouis 2.7.0 (as proposed in #4777] comment 7) won't be there in time for 2015.2, I believe that this bug should be fixed regardless of the progress in #4777.

They are also not available in 2.6.2. Depending on Joseph's results we could maybe switch to those new Danish tables, then update to 2.6.2 as per #4777 because these minor releases improve on the Danish tables as well.

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Mar 20, 2015

Comment 5 by jteh on 2015-03-20 23:44
Ug. This wasn't documented in the release notes for 2.6.0. Table renaming is a real problem for us, as it breaks existing users and new ones as well if it's not documented.

This shouldn't be blocked by #4777, as this needs to be done regardless and is actually more important.
Changes:
Milestone changed from None to 2015.2

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Mar 21, 2015

Comment 6 by dkager (in reply to comment 5) on 2015-03-21 08:35
Replying to jteh:

Ug. This wasn't documented in the release notes for 2.6.0.

Worse, this was already in 2.5.4 and possibly older versions. I can't find any indication of this in NEWS, though. Maybe the build process should do a quick check on orphaned tables?

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Mar 22, 2015

Comment 7 by dkager on 2015-03-22 12:54
Joseph, thanks again for posting this to the liblouis list! Saved me quite some hastle since I'm not subscribed with my home address. I noticed you've got a response.
Here's a topic branch for this issue: https://bitbucket.org/dkager/nvda/branch/t4986

This patch doesn't enable da-dk-g18.utb for input as suggested in the e-mail because "very close to a clean 8 dots char to char table" isn't good enough. Currently there is no Danish input table either, and adding one that almost works will probably lead to tickets pointing out the places where it doesn't.

Should fix this ticket and possibly #2835 as well (MHameed?).

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Apr 8, 2015

Comment 8 by James Teh <jamie@... on 2015-04-08 05:59
In [52aa9ee]:

Merge branch 't4986' into next

Incubates #4986.

Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Apr 23, 2015

Comment 9 by James Teh <jamie@... on 2015-04-23 04:14
In [e0215ee]:

Update Danish braille table references to point to the new tables in liblouis 2.6.0.

Fixes #4986.

Changes:
Removed labels: incubating
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.