Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid regex expressions in dictionaries no longer causes crash. #6136

Merged
merged 2 commits into from
Jul 20, 2016
Merged

Invalid regex expressions in dictionaries no longer causes crash. #6136

merged 2 commits into from
Jul 20, 2016

Commits on Jul 4, 2016

  1. Invalid regex expressions in dictionaries no longer causes crash. 

    Fixes #4834
    @feerrenrut
    feerrenrut committed Jul 4, 2016
    Configuration menu
    Copy the full SHA
    3070d5f View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2016

  1. ux improvements 

    When adding a dictionary entry with invalid regex, the error message now
states that this is a regex error and qoutes the error. It is
unfortunate, but the regex error is difficult to translate.

If a user does manage to introduce an error into a dictionary file, then
the nvda will import all valid lines in the file, reporting warnings to
the log for lines in the dictionary that are invalid.
    @feerrenrut
    feerrenrut committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    bb20eb3 View commit details
    Browse the repository at this point in the history