Enter should save changes and exit dictionary dialog #6296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a bug in wx (see wx ticket #3725) ListCtrl objects swallow keypresses (including enter). This is resolved by registering an event handler and forwarding enter presses to the dialog, and allowing thew ListCtrl to handle all others.
|
@jcsteh Could you review this when you get a chance? |
|
Looks fine to me! |
feerrenrut
added a commit
that referenced
this pull request
Aug 29, 2016
feerrenrut
added a commit
that referenced
this pull request
Sep 14, 2016
While in the dictionary dialog, pressing the enter key now saves changes and exits. (#6206)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #6206
Due to a bug in wx (see wx ticket #3725) ListCtrl objects swallow keypresses (including enter). This is resolved by registering an event handler and forwarding enter presses to the dialog, and allowing the ListCtrl to handle all others.