Ok button not default button in speech dictionary window #6206

Closed
Qchristensen opened this Issue Jul 25, 2016 · 3 comments

Comments

Projects
None yet
5 participants
@Qchristensen

When in NVDA's speech dictionary window, there is no default button. If you are not on a button and press ENTER, nothing happens. You have to TAB to the OK button in order to activate it.

@michaelDCurran michaelDCurran added the p2 label Jul 25, 2016

@ctoth

This comment has been minimized.

Show comment
Hide comment
@ctoth

ctoth Aug 19, 2016

It seems to me that the only item that is not actually a button in this window is the list, and I would actually expect that pressing enter on an item in the list would bring up the dialog to edit that item, which it does not.

ctoth commented Aug 19, 2016

It seems to me that the only item that is not actually a button in this window is the list, and I would actually expect that pressing enter on an item in the list would bring up the dialog to edit that item, which it does not.

@feerrenrut feerrenrut self-assigned this Aug 22, 2016

@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Aug 22, 2016

Contributor

Pressing ctrl + enter results in the pending changes being saved and the dialog closing, as if pressing the OK button.

This behaviour currently works in the symbol pronunciation dialog which has a similar pattern. However the pronunciation dialog has had to work around an issue in wx that causes this behaviour (according to the comments, wx ticket #3725). This should be trivial to fix, see onListChar in the SpeechSymbolsDialog class.

Contributor

feerrenrut commented Aug 22, 2016

Pressing ctrl + enter results in the pending changes being saved and the dialog closing, as if pressing the OK button.

This behaviour currently works in the symbol pronunciation dialog which has a similar pattern. However the pronunciation dialog has had to work around an issue in wx that causes this behaviour (according to the comments, wx ticket #3725). This should be trivial to fix, see onListChar in the SpeechSymbolsDialog class.

feerrenrut added a commit that referenced this issue Aug 23, 2016

Fix for issue #6206
Due to a bug in wx (see wx ticket #3725) ListCtrl objects swallow
keypresses (including enter). This is resolved by registering an event
handler and forwarding enter presses to the dialog, and allowing thew
ListCtrl to handle all others.
@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Aug 23, 2016

Contributor

Thanks @ctoth, you raise a good point there. However, for now I think we will try to keep this work flow consistent with the other dialogs. We are planning on re-working the UI shortly, and we will take this into account during that process.

As a side note, you can press alt+e to edit an item directly.

Contributor

feerrenrut commented Aug 23, 2016

Thanks @ctoth, you raise a good point there. However, for now I think we will try to keep this work flow consistent with the other dialogs. We are planning on re-working the UI shortly, and we will take this into account during that process.

As a side note, you can press alt+e to edit an item directly.

feerrenrut added a commit that referenced this issue Aug 29, 2016

incubates #6296
Fix for issue #6206

Merge remote-tracking branch 'origin/i6206-OKButtonNotDefault' into next

@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Sep 14, 2016

feerrenrut added a commit that referenced this issue Sep 14, 2016

Update changes file for PR #6296
While in the dictionary dialog, pressing the enter key now saves changes and exits. (#6206)

josephsl added a commit to josephsl/nvda that referenced this issue Oct 28, 2016

What's new: linguistic fixes and clarifications. re #6517, #6520
Specifically:
* #5906: Now labeled as 'line indentation reporting'.
* #6099: clarify how to change values in spin controls.
* #5886: elements list is available in browse mode.
* #6206: changed bits such as 'adding new entries'.
* #6127: no more hyphen (dash).
* #5050: 'causes' -> 'which caused'.
* #4164: changed wording to reflect that read-only edit fields are now included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment