Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install older version of pyAutoGui to make system tests on AppVeyor working again #9659

Merged
merged 2 commits into from
May 31, 2019

Conversation

lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented May 31, 2019

Link to issue number:

None

Summary of the issue:

Latest version of PyGetWindow cannot be installed under Python 2.7 see #9592 Unfortunately it is required when installing PyAutoGui 0.9.44. This currently causes system tests on AppVeyor to fail.

Description of how this pull request fixes the issue:

The older version of PyAutoGui is installed. In addition I've moved all ddependencies to the separate requirements file to make it easier for developers to install required version of packages on their machines, but also to update required version of dependencies in one place.

Testing performed:

Build and tests on AppVeyor succeeded. It is good to go.

Known issues with pull request:

None

Change log entry:

None needed

…h Python 2.7

* move all dependencies to the separate requirements file and use it when installing on AppVeyor
* update the readme for system tests accordingly
Copy link
Member

@michaelDCurran michaelDCurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work :)

@michaelDCurran michaelDCurran merged commit 8debe6a into nvaccess:master May 31, 2019
@nvaccessAuto nvaccessAuto added this to the 2019.2 milestone May 31, 2019
michaelDCurran pushed a commit that referenced this pull request May 31, 2019
…orking again (#9659)

* * Install older version of PyAutoGui as latest release don't work with Python 2.7
* move all dependencies to the separate requirements file and use it when installing on AppVeyor
* update the readme for system tests accordingly

* remove unneded line
@lukaszgo1 lukaszgo1 deleted the systemTestsFix3 branch June 1, 2019 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants