Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primordial Leaves has a bad loot table. Ultimining them breaks block drops #12

Closed
Trent2087 opened this issue Jan 23, 2024 · 3 comments
Closed

Comments

@Trent2087
Copy link

Primordial Leaves has a bad loot table.
[20:14:14] [ForkJoinPool.commonPool-worker-5/WARN]: [RER] Failed to parse loot table 'eldritch_end:blocks/primordial_leaves':
java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64) ~[?:?]
at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70) ~[?:?]
at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266) ~[?:?]
at java.util.Objects.checkIndex(Objects.java:361) ~[?:?]
at java.util.ArrayList.get(ArrayList.java:427) ~[?:?]
at com.google.gson.JsonArray.get(JsonArray.java:228) ~[gson-2.10.jar:?]
at uk.me.desert_island.rer.rei_stuff.LootDisplay.munchLootCondition(LootDisplay.java:200) ~[rer-2.9.0.jar:?]

This causes an error in the console whenever they are mined.
https://hastebin.com/share/odehikoyes.ruby

If Ultimine is used on the leaves, it breaks block drops for all items until a restart. Obviously this part is just a symptom. Fixing the loot table will also prevent this issue.

@Trent2087
Copy link
Author

Found the cause. After checking another mods leaves loot table, it appears you are missing the Explosion Chances in the json causing it to break. I added these chances to the loot table and that fixes the issue.
image

@nvb-uy
Copy link
Owner

nvb-uy commented Jan 24, 2024

Interesting lol, will get it fixed by next update, thanks!

@nvb-uy
Copy link
Owner

nvb-uy commented Jun 5, 2024

Fixed indev 0.3.0

@nvb-uy nvb-uy closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants