Skip to content

fix(test): timeout on windows, maybe fixes #636 #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(test): timeout on windows, maybe fixes #636 #1101

wants to merge 1 commit into from

Conversation

cameronr
Copy link
Contributor

@cameronr cameronr commented Aug 1, 2024

Fixes the timeout on basic Windows (no WSL). Didn't do extensive testing but passed my small number of tests:

Screenshot 2024-07-31 at 21 43 58

fix(test): timeout on windows, maybe fixes nvim-mini#636
049c9f9 
Fixes the timeout on basic Windows (no WSL).
@echasnovski
Copy link
Member

Thanks for the PR and the link with useful info!

I'll test this with 'mini.nvim' in GitHub Actions.

echasnovski added a commit that referenced this pull request Aug 3, 2024
@echasnovski @cameronr
feat(test): make it work on Windows
fe5067a 
Resolve #636

Resolve #1101

Co-authored-by: Cameron Ring <cameron@cs.stanford.edu>
@echasnovski
Copy link
Member

Thanks again for the PR!

It indeed seems to make 'mini.test' work on Windows. Finally!

However, this leaves me no excuse to enable Windows CI, which has ~350 fails out of ~4050 :( Most of them seem to be related to path differences and that Windows CI is slower. So I'll try to plough through fixing those before merging this change. Which may take a while :(

echasnovski added a commit that referenced this pull request Aug 5, 2024
@echasnovski @cameronr
feat(test): make it work on Windows
e215520 
Resolve #636

Resolve #1101

Co-authored-by: Cameron Ring <cameron@cs.stanford.edu>
echasnovski added a commit that referenced this pull request Aug 5, 2024
@echasnovski @cameronr
feat(test): make it work on Windows
bb09c1f 
Resolve #636

Resolve #1101

Co-authored-by: Cameron Ring <cameron@cs.stanford.edu>
echasnovski added a commit that referenced this pull request Aug 5, 2024
@echasnovski @cameronr
feat(test): make it work on Windows
798ca21 
Resolve #636

Resolve #1101

Co-authored-by: Cameron Ring <cameron@cs.stanford.edu>
echasnovski added a commit that referenced this pull request Aug 6, 2024
@echasnovski @cameronr
feat(test): make it work on Windows
f31ec3b 
Resolve #636

Resolve #1101

Co-authored-by: Cameron Ring <cameron@cs.stanford.edu>
@echasnovski
Copy link
Member

After a lot of trial and error using the infamous "CI debugging" approach, 'mini.nvim' is now automatically tested on Windows. All thanks to the solution from this PR which should be now part of main branch.

@cameronr, thanks again for this small in size but huge in consequences Windows pipe solution!

@echasnovski echasnovski mentioned this pull request Aug 10, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mini.test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cameronr @echasnovski