-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom text for mappings in help window #1186
Conversation
Cool, I don't believe I never thought of this before! I would say that it unnecessary to add a nested config object as the mapping is already a config object. I would also prefer the term I would change it to: ["<c-f>"] = {
function(state)
require("telescope.builtin").live_grep({ cwd = context_dir(state) })
end,
label = "live grep",
}, |
Changed ["<c-f>"] = {
function(state)
require("telescope.builtin").live_grep({ cwd = context_dir(state) })
end,
label = "live grep",
}, Will work now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I just realized there are no docs included so no one will ever even know this is possible! Can you add some docs?
Sure, it's been added to the documentation. I believe it should also be added to the 'wiki/Recipes,' but only after this feature has been merged. Not to mislead users. |
Ah, I wish I caught this earlier, would |
I don't mind replacing with a breaking change. It's unlikely that anyone but me is already using it. Just create a new PR |
Thanks @coffebar ! Just opened a PR. Let me know if I need to adjust anything. It might also not be considered a breaking change if it hasn't made it into a release yet. |
That's how I see it. |
With this feature, you can add labels for custom mappings (lua functions).
Example mapping with text:
Demo
Before
After