fix(mappings): Default offset encoding when handling <CR> press #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per here there are a number of functions that now require specifying an
offset_encoding
. Some examples of other updates to things like nvim-cmp and null-ls.Looking at all of those functions, this is the only one that I found that gets used in this plugin. As we do not have any attached clients, I do not see this being a huge issue (although I am also pretty naive in terms of the usage and impact) to follow the "norm" and use
utf-16
as a default.