Skip to content

Makes the property searching case insensitive #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

chuck-flowers
Copy link
Contributor

I noticed that in order to search agenda headlines using properties, the property names had to be all lower case. In Emacs, the property names are case insensitive when searching agenda items. I made a simple change to bring the behavior of nvim-orgmode in line with emacs.

@kristijanhusak
Copy link
Member

Good catch. Can you just please update tests to pass? props in tests needs to be lowercased (CATEGORY -> category) to make them pass. They are already lowercased in code when we search for headlines, so this is issue just in this isolated unit test.

@chuck-flowers
Copy link
Contributor Author

@kristijanhusak thanks for the feedback. I believe that I have updated all relevant tests. It seems that that the CI/CD build is passing again.

Copy link
Member

@kristijanhusak kristijanhusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks great! Thanks!

@kristijanhusak kristijanhusak merged commit 4e89bd0 into nvim-orgmode:master Nov 30, 2022
SlayerOfTheBad pushed a commit to SlayerOfTheBad/orgmode that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants