-
-
Notifications
You must be signed in to change notification settings - Fork 163
fix: update treesitter functions #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That depends on whether we want to ... um ... depend on it 😁 Sooner or later we will, but I let @kristijanhusak decide that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me (and fixes #536 for me).
@danilshvalov do you mind squashing your commits? I'm not sure why the tests are not re-running after I changed the target branch, but a force push from you should do the trick. |
582a65b
to
6d8d507
Compare
Done |
We are usually trying to support two latest versions + nightly, which will be 0.8.3, 0.9 and nightly, once the 0.9 is released. I'm ok with this, but we should probably make some wrapper around these and use appropriate one depending on the Neovim version. |
As this plugin already has nvim-treesitter as a dependency, using the shims from this commit seems ideal. Then there is no need for local wrappers |
I added the |
@danilshvalov in this case you can set the base branch back to |
1f1cb73
to
55d2f77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
On
0.8.[0|3]
I also need- a shim for
set_query
(used intodo_highlighter.lua:55
) - use
ts.get_qery
inmarkup_highlighter.lua:230
- use
ts.get_query_files
intodo_highlighter.lua:8
in order to not get errors.
- a shim for
-
On
nightly
I get a notice about deprecation ofvim.treesitter.query.get_query()
upon every startup. Can we avoid that?
Done
I can't reproduce it. Could you provide a log please? |
@jgollenz, is there anything else? |
@danilshvalov when I run the |
See neovim/neovim#22761 (maybe we should wait for the 0.9 release)