Limit _get_date_under_cursor to parsing current line #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To retrieve a date under the cursor, limit the scope to the current line. Parse all dates on the line, then filter the table to retrieve the member containing the cursor. Addresses the TODO that would fail to return the correct entry when multiple are found on a given line.
kristijanhusak
added a commit
that referenced
this pull request
Aug 19, 2024
|
I fixed the underlying issue in d0baf31 so this PR is not needed any more. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To retrieve a date under the cursor, limit the scope to the current line. Parse all dates on the line, then filter the table to retrieve the member containing the cursor.
Addresses the TODO that would fail to return the correct entry when multiple are found on a given line.
Closes #796