Added missing piece #1658
Merged
Added missing piece #1658
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sentence broke my brain when I read it the first time :) I hope this helps.
ljharb
requested changes
Nov 8, 2017
README.md
Outdated
| @@ -325,7 +325,7 @@ NVM_IOJS_ORG_MIRROR=https://iojs.org/dist nvm install iojs-v1.0.3 | |||
| ### .nvmrc | |||
|
|
|||
| You can create a `.nvmrc` file containing version number in the project root directory (or any parent directory). | |||
| `nvm use`, `nvm install`, `nvm exec`, `nvm run`, and `nvm which` will all respect an `.nvmrc` file when a version is not supplied. | |||
| `nvm use`, `nvm install`, `nvm exec`, `nvm run`, and `nvm which` will all respect an `.nvmrc` file when a version is not supplied in the command line. | |||
There was a problem hiding this comment.
LGTM - let's change this to on the command line :-)
There was a problem hiding this comment.
Hmm... I was thinking about that too. but it did sound strange, but English is not my first language, soo... I might be wrong, and for sure are, but still... are we sure that on is the best option here? :) I mean where are we when we type in the CLI, in it or on it :D
There was a problem hiding this comment.
I think both are correct, but the more common expression I've seen is "on" the command line.
ljharb
added a commit
to ljharb/nvm
that referenced
this pull request
Dec 9, 2017
Fixes - fix unassigned variable (nvm-sh#1665, nvm-sh#1664) - Fix for $path used by zsh (nvm-sh#1669) - `set -u`: ensure `NVM_USE_OUTPUT` is always set (nvm-sh#1671) - `install.sh`: Fix a bug that block that installation of node in install.sh (nvm-sh#1676) - `nvm install-latest-npm`: fix node 4-4.6 Documentation - Make `nvm cache clear` message less ambiguous (nvm-sh#1644) - Added missing piece (nvm-sh#1658)
edwmurph
pushed a commit
to edwmurph/nvm
that referenced
this pull request
Apr 9, 2018
Fixes - fix unassigned variable (nvm-sh#1665, nvm-sh#1664) - Fix for $path used by zsh (nvm-sh#1669) - `set -u`: ensure `NVM_USE_OUTPUT` is always set (nvm-sh#1671) - `install.sh`: Fix a bug that block that installation of node in install.sh (nvm-sh#1676) - `nvm install-latest-npm`: fix node 4-4.6 Documentation - Make `nvm cache clear` message less ambiguous (nvm-sh#1644) - Added missing piece (nvm-sh#1658)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sentence broke my brain when I read it the first time :) I hope this helps.