Fix a bug that block that installation of node in install.sh

[a-magdy]

Hi,

I found a bug in nvm_install_node function, it overrides the variable NODE_VERSION, which blocks the installation of node in the install.sh script! More details below..

I did some tests locally with the install.sh script, and the I found that the problem in in the function nvm_install_node in install.sh script.

One solution is to change the name of the local variable to something other than NODE_VERSION

You could test it using these 2 scripts:

I ran tests on ubuntu 16.04 servers

• Current version [0.33.6] test script:
  export NODE_VERSION=8 && sudo curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.6/install.sh | bash

Expected result: nvm should install node 8
Result: node 8 doesn't get installed

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 12492  100 12492    0     0  68946      0 --:--:-- --:--:-- --:--:-- 69016
=> nvm is already installed in /home/ubuntu/.nvm, trying to update using git
=> => Compressing and cleaning up git repository

=> nvm source string already in /home/ubuntu/.bashrc
=> bash_completion source string already in /home/ubuntu/.bashrc
=> Close and reopen your terminal to start using nvm or run the following to use it now:

export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion

• Proposed fix test script:
  export NODE_VERSION=8 && sudo curl -o- https://raw.githubusercontent.com/Quadric/nvm/fix-node-version-in-install-script/install.sh | bash

Result: node 8 is installed

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 12540  100 12540    0     0  48598      0 --:--:-- --:--:-- --:--:-- 48604
=> nvm is already installed in /home/ubuntu/.nvm, trying to update using git
=> => Compressing and cleaning up git repository

=> nvm source string already in /home/ubuntu/.bashrc
=> bash_completion source string already in /home/ubuntu/.bashrc
=> Installing Node.js version 8
v8.9.1 is already installed.
Now using node v8.9.1 (npm v5.5.1)
=> Node.js version 8 has been successfully installed
=> Close and reopen your terminal to start using nvm or run the following to use it now:

export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion

I wrote a test for it, and ran "test/install_script" on original repo and my fix, and surprisingly the test passes on both!! (https://github.com/Quadric/nvm/blob/fix-node-version-in-install-script/test/install_script/nvm_install_with_node_version), it doesn't change the fact that it still fails when I provision an AWS AMI with packer or when I run the script directly on the newly created machine!

thanks for you efforts :) 👍

[ljharb]

Thanks, good catch.