Optimize ShellCheck installation in Docker image #1729
Conversation
Use pre-built static release binary instead of building ShellCheck from the source code, this change would save disk space, time, and much computing resources.
There was a problem hiding this comment.
Thanks!
Incidentally, I now have a Dockerhub account. If I wanted to start publishing official docker images as part of the release process (to which I've also give you access), it'd be great if you could file an issue outlining the steps and what would be involved :-)
ljharb
force-pushed
the
improve-shellcheck-in-docker
branch
from
8584268
to
77da9f5
Compare
|
Yeah I can outline the steps, but I'd like to figure out the purpose of that image, if it's kind of nvm release, I'd like to hook the Docker Hub repository with this nvm repository. BTW, is it possible to also have access of this GitHub repository? Or maybe even move it under an organization? |
|
That’s a longer question and effort; we should proceed for now as if my lack of admin access to the repo, as well as it’s location, will continue unchanged. |
|
Yeah I understand, maybe can also discuss with @creationix ? |
|
Already have; as i said, it’s a longer effort and for the time being isn’t going to change. |
Use pre-built static release binary instead of building ShellCheck from the source code, this change would save disk space, time, and much computing resources.
Docker image size:
Original:
1.31GB, New:569MBCompressed Docker image size:
Original:
319MB, New:223MB(See: https://hub.docker.com/r/peterdavehello/nvm/tags/,
v0.33.8vsv0.33.8-new)It also saves more than 50% build time, 9:50 vs 4:15 on my computer.