Fix debug build for nw0.8 #2

libm · 2014-04-30T01:10:19Z

Back port part of a patch from 4dabdca to fix the debug build of 0.8 branch.

Back port a patch from 4dabdca to fix the debug build of 0.8 branch.

rogerwang · 2014-04-30T05:00:45Z

Interesting, the debug build for 0.8 is good for me here.

libm · 2014-05-07T02:17:59Z

../../third_party/WebKit/Source/bindings/v8/PageScriptDebugServer.cpp -o obj/third_party/WebKit/Source/bindings/v8/webcore_derived.PageScriptDebugServer.o
In file included from ../../third_party/WebKit/Source/wtf/HashTable.h:26:0,
                 from ../../third_party/WebKit/Source/wtf/HashMap.h:24,
                 from ../../third_party/WebKit/Source/core/platform/JSONValues.h:35,
                 from gen/blink/InspectorTypeBuilder.h:10,
                 from gen/blink/InspectorBackendDispatcher.h:9,
                 from ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.h:35,
                 from ../../third_party/WebKit/Source/bindings/v8/PageScriptDebugServer.h:35,
                 from ../../third_party/WebKit/Source/bindings/v8/PageScriptDebugServer.cpp:33:
../../third_party/WebKit/Source/bindings/v8/PageScriptDebugServer.cpp: In member function ‘void WebCore::PageScriptDebugServer::addListener(WebCore::ScriptDebugListener*, WebCore::Page*)’:
../../third_party/WebKit/Source/bindings/v8/PageScriptDebugServer.cpp:155:34: error: ‘class WebCore::ScopedPersistent<v8::Object>’ has no member named ‘get’
         ASSERT(!m_debuggerScript.get()->IsUndefined());
                                  ^
../../third_party/WebKit/Source/wtf/Assertions.h:208:8: note: in definition of macro ‘ASSERT’
     (!(assertion) ? \
        ^
ninja: build stopped: subcommand failed.

Fix debug build for nw0.8

This switches fastMalloc to PartitionAlloc for Android. Previously, we only used PartitionAlloc for fastMalloc on Mac OS X. According to primiano's measurements, this CL should improve PLT performance on Android by 7%. See referenced bug for details. alexa_us on N10 with default alloc (without # ms/page PSS Dirty #1 227.6 60410 44904 #2 226.1 61547 46008 #3 222.4 55595 40072 #4 224.2 57293 41728 AVG 225.1 58711 43178 alexa_us on N10 with partalloc # ms/page PSS Dirty #1 204.68 54862 39456 #2 208.73 59240 43844 #3 208.57 55164 39788 #4 217.28 58280 42904 AVG 209.81 56886 41498 BUG=312725 R=tonyg@chromium.org Review URL: https://codereview.chromium.org/148013010 git-svn-id: svn://svn.chromium.org/blink/trunk@166271 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…mpatible to tcmalloc R=esprehn@chromium.org TEST=Compile Android build with Deep Memory Profiler support. Go to lenta.ru. Open some news pages. Should not crash. ********** Crash dump: ********** Build fingerprint: 'samsung/GT-I9100/GT-I9100:4.0.3/IML74K/XXLPQ:user/release-keys' pid: 3431, tid: 3444 >>> org.chromium.content_shell_apk:sandboxed_process1 <<< signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 00000039 Stack frame #00 pc 02263b44 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Abort in ../../third_party/tcmalloc/chromium/src/base/abort.cc:15 Stack frame #1 pc 0226ccd8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Log in ../../third_party/tcmalloc/chromium/src/internal_logging.cc:120 Stack frame #2 pc 0227584c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine InvalidFree in (null):0 Stack frame #3 pc 02277698 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine do_free_with_callback in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1166 Stack frame #4 pc 02277898 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine do_free in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1209 Stack frame #5 pc 0229f914 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine tc_free in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1569 Stack frame #6 pc 0158af50 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine error in (null):0 Stack frame #7 pc 0158aff8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine normalErrorHandler in ../../third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:1305 Stack frame #8 pc 01166dac /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine __xmlRaiseError in ../../third_party/libxml/src/error.c:572 Stack frame #9 pc 0116b7a8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlFatalErr in (null):0 Stack frame #10 pc 0117e424 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlParseTryOrFinish in ../../third_party/libxml/src/parser.c:11453 Stack frame #11 pc 0117ea88 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlParseChunk in ../../third_party/libxml/src/parser.c:11767 Stack frame #12 pc 0158891c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine parseChunk in (null):0 Stack frame #13 pc 01589da0 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine doWrite in ../../third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:876 Stack frame #14 pc 01589f3c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine append in ../../third_party/WebKit/Source/wtf/RefPtr.h:49 Stack frame #15 pc 00d07e70 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine setContent in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:70 Stack frame #16 pc 015770bc /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXML in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:70 Stack frame #17 pc 017bdd20 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXMLAttributeGetter in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:47 Stack frame #18 pc 017bddc8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXMLAttributeGetterCallback in gen/blink/bindings/V8XMLHttpRequest.cpp:219 Stack frame #19 pc 00eb86d8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Call in ../../v8/src/arguments.cc:110 Stack frame #20 pc 01024b5c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetPropertyWithCallback in ../../v8/src/objects.cc:443 Stack frame #21 pc 010304c8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetProperty in ../../v8/src/objects.cc:971 Stack frame #22 pc 010305dc /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetProperty in ../../v8/src/objects.cc:845 Stack frame #23 pc 00fb12f8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Load in ../../v8/src/ic.cc:875 Stack frame #24 pc 00fb1b78 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine __RT_impl_LoadIC_Miss in ../../v8/src/ic.cc:2076 Stack frame #25 pc 00fb1bd0 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine LoadIC_Miss in (null):0 Review URL: https://codereview.chromium.org/143903018 git-svn-id: svn://svn.chromium.org/blink/trunk@166520 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…dereview.chromium.org/183793002/) Reason for revert: Possibly causing content_browsertests EndToEnd to fail. See: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2095/steps/content_browsertests/logs/stdio Output: [20917:20917:0327/122353:3268961829:INFO:CONSOLE(0)] "Uncaught TypeError: Cannot convert undefined or null to object", source: http://127.0.0.1:34379/files/web_ui_mojo.html (0) [20917:20917:0327/122353:3269022437:INFO:CONSOLE(28)] "Uncaught TypeError: undefined is not a function", source: http://127.0.0.1:34379/files/web_ui_mojo.js (28) BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x000000a593be base::debug::StackTrace::StackTrace() #1 0x000002bfc17b content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f9c3e4ab4a0 <unknown> #3 0x7f9c3e55da43 __poll #4 0x7f9c42aabff6 <unknown> #5 0x7f9c42aac124 g_main_context_iteration #6 0x000000aaaf5f base::MessagePumpGlib::RunWithDispatcher() #7 0x000000a8e802 base::RunLoop::Run() #8 0x00000058256e content::(anonymous namespace)::WebUIMojoTest_EndToEnd_Test::RunTestOnMainThread() Original issue's description: > Make start/stop loading notifications per-frame > > Also, make ProgressTracker a frame-level concept rather than a page-level concept and merge it with FrameLoader's FrameProgressTracker helper. Send per-frame progress change notifications accordingly. > > This depends on https://codereview.chromium.org/180113003/ landing in chromium. > > BUG=347643 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170192 TBR=abarth@chromium.org,japhet@chromium.org NOTREECHECKS=true NOTRY=true BUG=347643 Review URL: https://codereview.chromium.org/215533004 git-svn-id: svn://svn.chromium.org/blink/trunk@170218 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…ttps://codereview.chromium.org/215533004/) Reason for revert: r170192 was not a culprit. Original issue's description: > Revert of Make start/stop loading notifications per-frame (https://codereview.chromium.org/183793002/) > > Reason for revert: > Possibly causing content_browsertests EndToEnd to fail. > > See: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2095/steps/content_browsertests/logs/stdio > > Output: > [20917:20917:0327/122353:3268961829:INFO:CONSOLE(0)] "Uncaught TypeError: Cannot convert undefined or null to object", source: http://127.0.0.1:34379/files/web_ui_mojo.html (0) > [20917:20917:0327/122353:3269022437:INFO:CONSOLE(28)] "Uncaught TypeError: undefined is not a function", source: http://127.0.0.1:34379/files/web_ui_mojo.js (28) > BrowserTestBase signal handler received SIGTERM. Backtrace: > #0 0x000000a593be base::debug::StackTrace::StackTrace() > #1 0x000002bfc17b content::(anonymous namespace)::DumpStackTraceSignalHandler() > #2 0x7f9c3e4ab4a0 <unknown> > #3 0x7f9c3e55da43 __poll > #4 0x7f9c42aabff6 <unknown> > #5 0x7f9c42aac124 g_main_context_iteration > #6 0x000000aaaf5f base::MessagePumpGlib::RunWithDispatcher() > #7 0x000000a8e802 base::RunLoop::Run() > #8 0x00000058256e content::(anonymous namespace)::WebUIMojoTest_EndToEnd_Test::RunTestOnMainThread() > > Original issue's description: > > Make start/stop loading notifications per-frame > > > > Also, make ProgressTracker a frame-level concept rather than a page-level concept and merge it with FrameLoader's FrameProgressTracker helper. Send per-frame progress change notifications accordingly. > > > > This depends on https://codereview.chromium.org/180113003/ landing in chromium. > > > > BUG=347643 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170192 > > TBR=abarth@chromium.org,japhet@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=347643 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170218 TBR=abarth@chromium.org,japhet@chromium.org,enne@chromium.org NOTREECHECKS=true NOTRY=true BUG=347643 Review URL: https://codereview.chromium.org/216083002 git-svn-id: svn://svn.chromium.org/blink/trunk@170248 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…of a pointer (https://codereview.chromium.org/209713003/) Also reverting dependent patch https://codereview.chromium.org/213543004 Reason for revert: Likely to have caused memory leaks: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/989/steps/browser_tests/logs/stdio#failure1 (1) Direct leak of 32 byte(s) in 1 object(s) allocated from: #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 #1 0x9bdfd8a in WebCore::V8PerContextDataHolder::install(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:56 #2 0x9bdfa06 in WebCore::V8PerContextData::V8PerContextData(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:108 #3 0x9bc1afd in WebCore::V8PerContextData::create(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.h:66:16 #4 0x9be64fc in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132 (2) Indirect leak of 40 byte(s) in 1 object(s) allocated from: #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 #1 0x9b2ee18 in operator new third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:59:22 #2 0x9b2ee18 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53 #3 0x9be64e7 in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132 (3) Indirect leak of 24 byte(s) in 1 object(s) allocated from: #0 0x4b46c1 in __interceptor_malloc /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75 #1 0x62caf0a in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:533 #2 0x62caf0a in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:549 #3 0x62caf0a in WTF::fastMalloc(unsigned long) third_party/WebKit/Source/wtf/FastMalloc.cpp:125 #4 0x9b2ed61 in operator new third_party/WebKit/Source/wtf/RefCounted.h:175 #5 0x9b2ed61 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53 Original issue's description: > Make DOMWrapperWorld::current() return a reference instead of a pointer > > Now that it's guaranteed that DOMWrapperWorld is not 0 at any given time, we can make it a reference instead of a pointer. > > BUG=341032 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170261 TBR=jochen@chromium.org,dcarney@chromium.org,abarth@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true BUG=341032 Review URL: https://codereview.chromium.org/217053007 git-svn-id: svn://svn.chromium.org/blink/trunk@170357 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a revert of the revert of r170261. r170261 was reverted because it introduced new memory leaks, but the leaks were false-positive. > Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer (https://codereview.chromium.org/209713003/) > > Also reverting dependent patch https://codereview.chromium.org/213543004 > > Reason for revert: > Likely to have caused memory leaks: > http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/989/steps/browser_tests/logs/stdio#failure1 > > (1) > Direct leak of 32 byte(s) in 1 object(s) allocated from: > #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 > #1 0x9bdfd8a in WebCore::V8PerContextDataHolder::install(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:56 > #2 0x9bdfa06 in WebCore::V8PerContextData::V8PerContextData(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:108 > #3 0x9bc1afd in WebCore::V8PerContextData::create(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.h:66:16 > #4 0x9be64fc in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132 > > (2) > Indirect leak of 40 byte(s) in 1 object(s) allocated from: > #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 > #1 0x9b2ee18 in operator new third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:59:22 > #2 0x9b2ee18 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53 > #3 0x9be64e7 in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132 > > (3) > Indirect leak of 24 byte(s) in 1 object(s) allocated from: > #0 0x4b46c1 in __interceptor_malloc /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75 > #1 0x62caf0a in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:533 > #2 0x62caf0a in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:549 > #3 0x62caf0a in WTF::fastMalloc(unsigned long) third_party/WebKit/Source/wtf/FastMalloc.cpp:125 > #4 0x9b2ed61 in operator new third_party/WebKit/Source/wtf/RefCounted.h:175 > #5 0x9b2ed61 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53 > > Original issue's description: > > Make DOMWrapperWorld::current() return a reference instead of a pointer > > > > Now that it's guaranteed that DOMWrapperWorld is not 0 at any given time, we can make it a reference instead of a pointer. > > > > BUG=341032 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170261 > > TBR=jochen@chromium.org,dcarney@chromium.org,abarth@chromium.org,haraken@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=341032 > > Review URL: https://codereview.chromium.org/217053007 TBR=enne@chromium.org Review URL: https://codereview.chromium.org/218813002 git-svn-id: svn://svn.chromium.org/blink/trunk@170424 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the final patch in a three-part series towards early termination of flings when scrolling is impossible, cleaning up now unused portions of the WebGestureCurveTarget interface. Blink patch (#1) https://codereview.chromium.org/139493003/ Chromium patch (#2): https://codereview.chromium.org/136173004/ Review URL: https://codereview.chromium.org/217893004 git-svn-id: svn://svn.chromium.org/blink/trunk@170887 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…nd shorthand background-repeat serialization did not handle initial keyword values in background-repeat value lists. Initial values in value lists are introduced by setting the background shorthand to multiple background values while omitting background-repeat properties. Example: background: url(#1), url(#2), url(#3); The background-repeat gets stored internally as "initial, initial, initial". This patch updates StylePropertySerializer::backgroundRepeatPropertyValue() to handle this case correctly. BUG=378167 Review URL: https://codereview.chromium.org/303993003 git-svn-id: svn://svn.chromium.org/blink/trunk@175261 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This ctor is expected to be added to the spec: w3c/ServiceWorker#192 Eventually we'll also have ctors for String, Stream, and ArrayBuffer bodies. Multi-sided patch to implement blob-type fetch event response bodies: #1: blink-side, THIS PATCH #2: chromium-side: https://codereview.chromium.org/304153015/ #3: blink-side: https://codereview.chromium.org/304233017 BUG=379074 Review URL: https://codereview.chromium.org/307063002 git-svn-id: svn://svn.chromium.org/blink/trunk@175350 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…//codereview.chromium.org/312683005/) Reason for revert: This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905 BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace() #1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f2c232cd4a0 \u003Cunknown> #3 0x7f2c2337f313 __poll #4 0x7f2c240b6036 \u003Cunknown> #5 0x7f2c240b6164 g_main_context_iteration #6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run() #7 0x7f2c2a29eed7 base::MessageLoop::RunHandler() #8 0x7f2c2a2f69d8 base::RunLoop::Run() #9 0x00000466bd59 content::RunThisRunLoop() #10 0x00000466c1b8 content::MessageLoopRunner::Run() #11 0x000004610946 content::TitleWatcher::WaitAndGetTitle() #12 0x0000011fdf00 MediaBrowserTest::RunTest() #13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage() #14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage() #15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange() #16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread() ... Please look into it. An alterate possible candidate is https://codereview.chromium.org/327553002 but I think that's less likely. Original issue's description: > IDL: Support optional argument default value syntax > > Adds support for parsing default values of different types, but > only handles null default values when generating code. > > Replaces existing > > [Default=Null] optional SomeInterface arg > [Default=NullString] optional DOMString arg > > with the now equivalent > > optional SomeInterface arg = null > optional DOMString arg = null > > in IDL files, and drops support for those [Default] attributes. > > No changes to generated code. > > BUG=258153 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200 TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com NOTREECHECKS=true NOTRY=true BUG=258153 Review URL: https://codereview.chromium.org/339683002 git-svn-id: svn://svn.chromium.org/blink/trunk@176220 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…ax (https://codereview.chromium.org/339683002/) Reason for revert: Revert the revert because the bot went green even without this revert, and other bots had no trouble. Original issue's description: > Revert of IDL: Support optional argument default value syntax (https://codereview.chromium.org/312683005/) > > Reason for revert: > This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905 > > BrowserTestBase signal handler received SIGTERM. Backtrace: > #0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace() > #1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #2 0x7f2c232cd4a0 \u003Cunknown> > #3 0x7f2c2337f313 __poll > #4 0x7f2c240b6036 \u003Cunknown> > #5 0x7f2c240b6164 g_main_context_iteration > #6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run() > #7 0x7f2c2a29eed7 base::MessageLoop::RunHandler() > #8 0x7f2c2a2f69d8 base::RunLoop::Run() > #9 0x00000466bd59 content::RunThisRunLoop() > #10 0x00000466c1b8 content::MessageLoopRunner::Run() > #11 0x000004610946 content::TitleWatcher::WaitAndGetTitle() > #12 0x0000011fdf00 MediaBrowserTest::RunTest() > #13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage() > #14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage() > #15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange() > #16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread() > ... > > Please look into it. An alterate possible candidate is https://codereview.chromium.org/327553002 but I think that's less likely. > > Original issue's description: > > IDL: Support optional argument default value syntax > > > > Adds support for parsing default values of different types, but > > only handles null default values when generating code. > > > > Replaces existing > > > > [Default=Null] optional SomeInterface arg > > [Default=NullString] optional DOMString arg > > > > with the now equivalent > > > > optional SomeInterface arg = null > > optional DOMString arg = null > > > > in IDL files, and drops support for those [Default] attributes. > > > > No changes to generated code. > > > > BUG=258153 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200 > > TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com > NOTREECHECKS=true > NOTRY=true > BUG=258153 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176220 TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com NOTREECHECKS=true NOTRY=true BUG=258153 Review URL: https://codereview.chromium.org/339723002 git-svn-id: svn://svn.chromium.org/blink/trunk@176231 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…ructed Currently an unresolved Promise on RespondWithObserver is forcibly rejected when the RespondWithObserver is destructed. This means that an unresolved Promise registered with fetchEvent.respondWith() is forcibly rejected when the fetchEvent is destructed. This behavior is not good because it makes GC observable. (For more details, see comment #2 and #4 in the CL discussion.) Given the above, this CL stops rejecting an unresolved Promise in RespondWithObserver's destructor. Also this CL removes a test that were testing the behavior. The removed test should hang after this change (because an unresolved Promise is never resolved nor rejected). BUG=400645 Review URL: https://codereview.chromium.org/442183003 git-svn-id: svn://svn.chromium.org/blink/trunk@179695 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…ots first and conservative second. (http… (patchset #2 of https://codereview.chromium.org/413133006/) Reason for revert: This breaks strongification of ephemerons when there are pointers on the stack. See: https://codereview.chromium.org/461413002/ for details. Original issue's description: > Revert "Revert of [oilpan]: Change marking to do precise roots first and conservative second. (https://codereview.chromium.org/405403003/)" > > This reverts commit 765af3a. > > AFAICT the CrossThreadPointerToOrphanedPage test was a bit flaky in the sense that the compiler was free to reuse the slot where the stackPtrValue was located after the RELEASE_ASSERT. However the test assumed the stackPtrValue was on the stack (to mimic a rogue integer value finding a dead object) when doing the conservative GC further down. > After my change to Heap::CollectGarbage it seemed the android compiler no longer kept the value around and hence the test started failing. I have now moved the RELEASE_ASSERT down to after the point where we do the conservative GC which makes the test pass on android again. > > I uploaded the unfixed diff first and then a second diff (moved RELEASE_ASSERT) with the fix. > > R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com, tkent@chromium.org, zerny@chromium.org > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178845 NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/464253002 git-svn-id: svn://svn.chromium.org/blink/trunk@180160 bbb929c8-8fbe-4397-9dbb-9b2b20218538

of https://codereview.chromium.org/475803002/) Reason for revert: 'common' should not be aware of profiler. Original issue's description: > Make profiling lock global rather than per Target > > We should pause any actions that could affect performance if any of the targets is being profiled, not only current target. > > BUG=403684 > R=sergeyv@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180336 TBR=sergeyv@chromium.org,apavlov@chromium.org,yurys@chromium.org NOTREECHECKS=true NOTRY=true BUG=403684 Review URL: https://codereview.chromium.org/471393002 git-svn-id: svn://svn.chromium.org/blink/trunk@180342 bbb929c8-8fbe-4397-9dbb-9b2b20218538

or debug callback can't get the listener. Fix nwjs/nw.js#719 #0 WebCore::InspectorDebuggerAgent::didPause (this=0x7ffff7ee8800, scriptState=0x192e07eebb10, callFrames=..., exception=...) at ../../third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp:682 #1 0x0000000003665f7e in WebCore::ScriptDebugServer::breakProgram ( this=0x7ffff7ee8260, executionState=..., exception=...) at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:425 nwjs#2 0x0000000003666ceb in WebCore::ScriptDebugServer::handleV8DebugEvent ( this=0x7ffff7ee8260, eventDetails=...) at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:503 nwjs#3 0x0000000003666012 in WebCore::ScriptDebugServer::v8DebugEventCallback ( eventDetails=...) at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:435 nwjs#4 0x0000000000f7ecb3 in v8::internal::Debugger::CallCEventCallback ( this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=..., client_data=0x0) at ../../v8/src/debug.cc:2953 nwjs#5 0x0000000000f7ebf9 in v8::internal::Debugger::CallEventCallback ( this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=..., client_data=0x0) at ../../v8/src/debug.cc:2932 nwjs#6 0x0000000000f7eabd in v8::internal::Debugger::ProcessDebugEvent ( this=0x7ffff7eec520, event=v8::Break, event_data=..., auto_continue=false) at ../../v8/src/debug.cc:2909 nwjs#7 0x0000000000f7e24d in v8::internal::Debugger::OnDebugBreak ( this=0x7ffff7eec520, break_points_hit=..., auto_continue=false) at ../../v8/src/debug.cc:2750 nwjs#8 0x0000000000f7836f in v8::internal::Debug::Break (this=0x7ffff7eecc20, args=...) at ../../v8/src/debug.cc:992 nwjs#9 0x0000000000f787a8 in v8::internal::__RT_impl_Debug_Break (args=..., isolate=0x7ffff7e80020) at ../../v8/src/debug.cc:1062 nwjs#10 0x0000000000f78769 in v8::internal::Debug_Break (args_length=0, args_object=0x7fffffff8248, isolate=0x7ffff7e80020) at ../../v8/src/debug.cc:1061

…leased (patchset nwjs#2 id:20001 of https://codereview.chromium.org/836023004/) Reason for revert: Speculative revert. WebKit XP bot has lots of LayoutTest failures and crashes in virtual/display_list_2d_canvas and virtual/gpu/fast/canvas. See eg: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/16116 The failures started on: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/16113 Chrome revision range: https://chromium.googlesource.com/chromium/src/+log/5b35ed504ba27664bc0b7d7320f2ebdf610decdc..3a5e72899629e0c8d254109707e747742686fbca Blink revision range: http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=187921%3A187936&mode=html Original issue's description: > Changing ASSERT for CRASH in Canvas2DLayerBridge::mailboxReleased > > This is an exploratory patch to determine whether the crash reports > associated with bug 443898 are caused by unrecognized mailbox names. > > BUG=443898 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187932 TBR=danakj@chromium.org,junov@chromium.org NOTREECHECKS=true NOTRY=true BUG=443898 Review URL: https://codereview.chromium.org/796373004 git-svn-id: svn://svn.chromium.org/blink/trunk@187960 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…:mailboxReleased (patchset nwjs#1 id:1 of https://codereview.chromium.org/796373004/) Reason for revert: The revert did not fix the Win XP failures. Original issue's description: > Revert of Changing ASSERT for CRASH in Canvas2DLayerBridge::mailboxReleased (patchset nwjs#2 id:20001 of https://codereview.chromium.org/836023004/) > > Reason for revert: > Speculative revert. WebKit XP bot has lots of LayoutTest failures and crashes in virtual/display_list_2d_canvas and virtual/gpu/fast/canvas. > > See eg: > http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/16116 > > The failures started on: > http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/16113 > > Chrome revision range: > https://chromium.googlesource.com/chromium/src/+log/5b35ed504ba27664bc0b7d7320f2ebdf610decdc..3a5e72899629e0c8d254109707e747742686fbca > > Blink revision range: > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=187921%3A187936&mode=html > > > Original issue's description: > > Changing ASSERT for CRASH in Canvas2DLayerBridge::mailboxReleased > > > > This is an exploratory patch to determine whether the crash reports > > associated with bug 443898 are caused by unrecognized mailbox names. > > > > BUG=443898 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187932 > > TBR=danakj@chromium.org,junov@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=443898 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187960 TBR=danakj@chromium.org,junov@chromium.org NOTREECHECKS=true NOTRY=true BUG=443898 Review URL: https://codereview.chromium.org/824753004 git-svn-id: svn://svn.chromium.org/blink/trunk@187961 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch simply adds a layout test to verify and lock-in the behavior changes from patches nwjs#1 and nwjs#2. Patch 1: https://codereview.chromium.org/821383008/ Patch 2: https://codereview.chromium.org/842643002/ Patch 3: [THIS PATCH] BUG=442662 Review URL: https://codereview.chromium.org/841693002 git-svn-id: svn://svn.chromium.org/blink/trunk@188036 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…erflow. (patchset nwjs#2 id:20001 of https://codereview.chromium.org/837033003/) Reason for revert: broke WebKit Mac Builder in the meantime: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder/builds/109166 Original issue's description: > Simplify InlineFlowBox::add{BoxShadow,BorderOutset}VisualOverflow. > > BUG=445050 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188064 TBR=fmalita@chromium.org NOTREECHECKS=true NOTRY=true BUG=445050 Review URL: https://codereview.chromium.org/810033008 git-svn-id: svn://svn.chromium.org/blink/trunk@188066 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The POWER spec[1] defines a set of characteristics which should only be made available over secure connections. Since we've already released a number of APIs that fit the bill, we're going to have to go through some deprecation process over time. This patch adds blink-side tests to lock in the behavior change from patches nwjs#1 and nwjs#2. Patch 1 (Blink): https://codereview.chromium.org/843953002/ Patch 2 (content): https://codereview.chromium.org/842183002/ Patch 3 (Blink): [THIS PATCH] BUG=447525 R=jochen@chromium.org Review URL: https://codereview.chromium.org/839213002 git-svn-id: svn://svn.chromium.org/blink/trunk@188186 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…tchset nwjs#2 id:20001 of https://codereview.chromium.org/780223004/) Reason for revert: Disabling touch adjustment on mobile sites makes checkbox touch interaction exceedingly difficult. Original issue's description: > Disable touch adjustment for mobile-optimized viewports > > Use the existing |WebViewImpl::shouldDisableDesktopWorkarounds()| signal > to suppress touch adjustment for tap-related events. When the content > is optimized for the device viewport, the adjustment should not be > necessary. > > BUG=417534 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186818 TBR=aelias@chromium.org,rbyers@chromium.org BUG=417534,448532 Review URL: https://codereview.chromium.org/825353009 git-svn-id: svn://svn.chromium.org/blink/trunk@188494 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…wjs#2 id:20001 of https://codereview.chromium.org/814123005/) Reason for revert: Revert change as it inadvertently reverted a performance optimization. See https://codereview.chromium.org/18099004/ Original issue's description: > Small cleanup in PNGImageDecoder::rowAvailable. > > ImageFrame::setRGBA checks if premultiplyAlpha is true or not. So we can simplify several 'for' loops into one. > > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188519 TBR=shivamidow@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/854213002 git-svn-id: svn://svn.chromium.org/blink/trunk@188538 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…ck to play/pause) (patchset nwjs#2 id:20001 of https://codereview.chromium.org/829393004/) Reason for revert: On Android: 1. The entire video is now clickable, leading more often to ambigous touches and zooming. 2. When the controls are not visible, touching the video will both pause the video and show the controls, where they would previously only show the controls. Original issue's description: > Re-re-enable the activation behavior of media elements (click to play/pause) > > The previous attempt broke the overlay play button: > https://codereview.chromium.org/830183005/#msg15 > > Drop the changes to MediaControlOverlayPlayButtonElement and add a test. > > BUG=354746 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188233 TBR=fs@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=354746 Review URL: https://codereview.chromium.org/867063003 git-svn-id: svn://svn.chromium.org/blink/trunk@188869 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…inters to incomplete types (patchset nwjs#2 id:20001 of https://codereview.chromium.org/412483007/) Reason for revert: This should no longer be necessary; clang should be able to handle this now. Reverting this to test that theory. Original issue's description: > Add explicit destructors to DOM classes containing smart pointers to incomplete types > > Clang on Windows tries to declare the implicit virtual destructor of > these classes so that it can diagnose mismatched exceptions > specifications. This ends up requiring that the type of the smart > pointer be complete, which it is not. This codepath does not fire on > non-Windows platforms due to the Itanium C++ ABI key function > optimization. > > It is possible to fix Clang to avoid performing semantic analysis of the > destructor when it only needs to compute the exception specification, > but it is prohibitively difficult. http://llvm.org/PR20337 > > Another possible fix on the Blink side would be to make the smart > pointer type complete by including the relevant header, which has the > cost of increasing transitive header bloat. Instead, simply define the > destructor out of line. This is also a minor object file size > optimization, as now the destructor is only emitted once. > > R=thakis@chromium.org > BUG=82385 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178838 TBR=rnk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=82385 Review URL: https://codereview.chromium.org/878273002 git-svn-id: svn://svn.chromium.org/blink/trunk@189052 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The event is being deprecated in favor of using GestureScrollUpdate. All relevant LayoutTests are updated to use the new method available in EventSender. This patch is part of a series: patch #1: https://codereview.chromium.org/703983002 patch #2: https://codereview.chromium.org/729533003 patch #3: This CL BUG=416596 Review URL: https://codereview.chromium.org/732483003 git-svn-id: svn://svn.chromium.org/blink/trunk@186303 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…ecodes of background/border images (patchset #1 id:1 of https://codereview.chromium.org/766133002/) Reason for revert: This will re-land the original CL, as it appears to have no effect on the perf test referred to in BUG=437496 Original issue's description: > Revert of Timeline: fix URLs and owner elements for image decodes of background/border images (patchset #2 id:20001 of https://codereview.chromium.org/755633002/) > > Reason for revert: > Speculative revert to see whether this really could be a reson for https://code.google.com/p/chromium/issues/detail?id=437496 > > Original issue's description: > > Timeline: fix URLs and owner elements for image decodes of background/border images > > > > We rely on PaintImage events to provide context information available > > on the rendering level (image URLs and owning node id) for nested > > DecodeImage and ResizeImage events. However, we only had PaintImage > > emitted when painting an Image element. This adds similar events for > > images that are painted as backgrounds and borders. > > > > BUG=434905 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186030 > > TBR=chrishtr@chromium.org,yurys@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=434905 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186218 TBR=chrishtr@chromium.org,yurys@chromium.org NOTREECHECKS=true NOTRY=true BUG=434905 Review URL: https://codereview.chromium.org/768353002 git-svn-id: svn://svn.chromium.org/blink/trunk@186307 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…ery. (patchset #2 id:20001 of https://codereview.chromium.org/755993002/) Reason for revert: Made framework-stepping tests timeout. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Fsources%2Fdebugger%2Fframeworks-steppings.html&testType=layout-tests Original issue's description: > DevTools: Make framework blackboxing properly work with jQuery. > > This bumps up the max limit on StepFrame's from 50 to 1024, although the test starts passing when the limit is 66. > > BUG=401497 > R=yurys@chromium.org, vsevik, yurys > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186243 TBR=vsevik@chromium.org,yurys@chromium.org,aandrey@chromium.org NOTREECHECKS=true NOTRY=true BUG=401497 Review URL: https://codereview.chromium.org/774983002 git-svn-id: svn://svn.chromium.org/blink/trunk@186371 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…ps://codereview.chromium.org/766683004/) Reason for revert: Crashes on Mac 10.7, possibly others that haven't built yet. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=fast/css/font-face-zero-hash-key.html Original issue's description: > Unify FontPlatformData hashing > > FontPlatformData hashing on Mac fails to separate instances > if m_font is zero and only m_cgFont is used, which is the case > for web fonts. Since we plan to get rid of the platform specific > m_font, m_cgFont etc. members anyway, let's start by unifying > hashing. I don't expect a slowdown from getting the m_typeface > since it's needed at the painting stage anyway. > > BUG=414234 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186426 TBR=eae@chromium.org,jbroman@chromium.org,derat@chromium.org,fmalita@google.com,dominik.rottsches@intel.com NOTREECHECKS=true NOTRY=true BUG=414234 Review URL: https://codereview.chromium.org/777013002 git-svn-id: svn://svn.chromium.org/blink/trunk@186443 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…de (patchset #2 id:20001 of https://codereview.chromium.org/741493004/) Reason for revert: Testing to see if revert fixes https://code.google.com/p/chromium/issues/detail?id=435816 If it does then the best solution is to find the actual root cause and re-land or at least tweak the yielding logic to make it more likely to only yield for the specific cases we are targeting. This is a manual patch set as the auto-generated revert from the original patch would not apply: https://codereview.chromium.org/779653002/ Original issue's description: > Yield parser before scripts if a lot of DOM changes were made > > Yield the main parser thread when processing chunks from the background > parser if a script block is about to be started and a large number of > DOM elements have been parsed in the current session. > > This significantly helps initial render (6-8% in testing) at a slight > cost to DOM Content Loaded (~2% in testing) generally but has a large > benefit in particular for sites that put scripts at the end of their > document (which is a common best-practice). > > BUG=427757 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185567 Review URL: https://codereview.chromium.org/768133002 git-svn-id: svn://svn.chromium.org/blink/trunk@186473 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…20001 of https://codereview.chromium.org/771403004/) Reason for revert: Reverting because the test times out on all the debug bots (90s) and Oilpan and MSAN and others. Please try for something other than just marking as flaky or failing. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Fsources%2Fdebugger%2Fframeworks-pause-button.html&testType=layout-tests Original issue's description: > DevTools: Skip blackboxed frames on pause. > > BUG=428236 > R=pfeldman, yurys > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186503 TBR=pfeldman@chromium.org,yurys@chromium.org,aandrey@chromium.org NOTREECHECKS=true NOTRY=true BUG=428236 Review URL: https://codereview.chromium.org/777243003 git-svn-id: svn://svn.chromium.org/blink/trunk@186523 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…es were made (patchset #2 id:20001 of https://codereview.chromium.org/768133002/) Reason for revert: Reverting the revert (re-landing the original). The crash that triggered the revert test only ever happened once and can not be reproduced with or without the CL (and the CL wouldn't logically have anything to do with it other than being the last thing that touched code near the call stack). Original issue's description: > Revert of Yield parser before scripts if a lot of DOM changes were made (patchset #2 id:20001 of https://codereview.chromium.org/741493004/) > > Reason for revert: > Testing to see if revert fixes https://code.google.com/p/chromium/issues/detail?id=435816 > > If it does then the best solution is to find the actual root cause and re-land or at least tweak the yielding logic to make it more likely to only yield for the specific cases we are targeting. > > This is a manual patch set as the auto-generated revert from the original patch would not apply: https://codereview.chromium.org/779653002/ > > Original issue's description: > > Yield parser before scripts if a lot of DOM changes were made > > > > Yield the main parser thread when processing chunks from the background > > parser if a script block is about to be started and a large number of > > DOM elements have been parsed in the current session. > > > > This significantly helps initial render (6-8% in testing) at a slight > > cost to DOM Content Loaded (~2% in testing) generally but has a large > > benefit in particular for sites that put scripts at the end of their > > document (which is a common best-practice). > > > > BUG=427757 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185567 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186473 TBR=kouhei@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/784973003 git-svn-id: svn://svn.chromium.org/blink/trunk@186743 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In the Blink, we add a flag to decide if Ctrl-wheel-scroll should scroll or zoom. For all cases we will be doing a zoom with the wheel, except touchpad scrolling for ChromeOS and all scrolling on MacOS. There are some changes made in chromium and an unit test file which depends on chromium change in the below patchs. follow-up patch #2: https://codereview.chromium.org/739013008 follow-up patch #3: https://codereview.chromium.org/768443002 BUG=397027, 378755 Review URL: https://codereview.chromium.org/759073002 git-svn-id: svn://svn.chromium.org/blink/trunk@186780 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…ps://codereview.chromium.org/735083002/) Reason for revert: The flag is not used. Original issue's description: > Add RenderObject::needsPaint() > > This is for slimming paint to determine which RenderObjects need paint > instead of managing a invalidated renderer hashset. > > For now the flag is set in RenderObject::invalidatePaintUsingContainer(). > It should be reset when the object is painted (not in this change). > > BTW, changed invalidation methods to non-const because > - they needs to modify this flag; > - they actually changed other underlying data so should not be of const > semantic > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185553 TBR=chrishtr@chromium.org,pdr@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/793523002 git-svn-id: svn://svn.chromium.org/blink/trunk@186822 bbb929c8-8fbe-4397-9dbb-9b2b20218538

id:20001 of https://codereview.chromium.org/783113002/) Reason for revert: Speculative revert: test DumpAccessibilityTreeTest.AccessibilityAriaMenuItemRadio is failing on win8 Flakiness Dashboard: http://goo.gl/rvwUyf Example build: http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/36678 Original issue's description: > Added test to check the state of ARIA checkboxes. > > Provided also some logic to check mixed state for > radio and menu item radio roles. W3c spec says to treat them as false. > > BUG=170576,418013 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186852 TBR=dmazzoni@chromium.org,k.czech@samsung.com NOTREECHECKS=true NOTRY=true BUG=170576,418013 Review URL: https://codereview.chromium.org/789403004 git-svn-id: svn://svn.chromium.org/blink/trunk@186948 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…d:20001 of https://codereview.chromium.org/797243002/) Reason for revert: This patchset likely introduced a build failure: http://build.chromium.org/p/chromium.webkit/builders/Mac%20Builder%20%28dbg%29/builds/70380 Original issue's description: > convert generated bindings to handle symbols > > callbacks taking v8::String will be deprecated soon. additionally the new api will support removal of the Get/HasRealNamed.... checks. > > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187028 TBR=dcarney@chromium.org NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/799013002 git-svn-id: svn://svn.chromium.org/blink/trunk@187030 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…chset #1 id:1 of https://codereview.chromium.org/799013002/) Reason for revert: this patch is very unlikely to have caused that fallure, trying again Original issue's description: > Revert of convert generated bindings to handle symbols (patchset #2 id:20001 of https://codereview.chromium.org/797243002/) > > Reason for revert: > This patchset likely introduced a build failure: > > http://build.chromium.org/p/chromium.webkit/builders/Mac%20Builder%20%28dbg%29/builds/70380 > > Original issue's description: > > convert generated bindings to handle symbols > > > > callbacks taking v8::String will be deprecated soon. additionally the new api will support removal of the Get/HasRealNamed.... checks. > > > > BUG= > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187028 > > TBR=dcarney@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187030 TBR=ellyjones@chromium.org NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/800973002 git-svn-id: svn://svn.chromium.org/blink/trunk@187046 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…#2 id:20001 of https://codereview.chromium.org/724273002/) Reason for revert: Going with "inputmode" for auto-cap configuration instead of non-stanrdard "autocapitalize" (as used by Safari). Original issue's description: > Add autocapitalize support for use by Android IME. > > BUG=116152 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186208 TBR=darin@chromium.org,tkent@chromium.org NOTREECHECKS=true NOTRY=true BUG=116152 Review URL: https://codereview.chromium.org/799063003 git-svn-id: svn://svn.chromium.org/blink/trunk@187060 bbb929c8-8fbe-4397-9dbb-9b2b20218538

id:20001 of https://codereview.chromium.org/793243004/) Reason for revert: seems to be causing compile failures: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/101401/steps/compile/logs/stdio Original issue's description: > IDL: Properly support [Exposed] on static methods > > They were conditionally installed as indicated by the [Exposed] attribute, > but they were installed on the prototype object rather than on the > interface object. > > A static method with [Exposed] fulfills the requirements for being treated > both as a conditionally enabled method (because of [Exposed]) and a method > with custom registration (because of being static), and due to the order > in which those requirements were checked, it ended up being treated as a > conditionally enabled method, only. > > Fix by giving custom registration priority and by adding the same > condition filters around that registration code, so that such methods can > still also be all sorts of conditionally enabled. > > BUG=434741 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187161 TBR=haraken@chromium.org,jl@opera.com NOTREECHECKS=true NOTRY=true BUG=434741 Review URL: https://codereview.chromium.org/806773006 git-svn-id: svn://svn.chromium.org/blink/trunk@187182 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…tchset #2 id:20001 of https://codereview.chromium.org/722423004/) Reason for revert: Crashing, see bug 441968 Original issue's description: > Remove WindowFocusAllowedIndicator and associated code. > > This is the last part of a three-sided CL: > Part 1: https://codereview.chromium.org/777483004/ > Part 2: https://codereview.chromium.org/786403003/ > Part 3: <this> > > BUG=440740 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187135 TBR=jochen@chromium.org,mkwst@chromium.org,mlamouri@chromium.org NOTREECHECKS=true NOTRY=true BUG=440740 Review URL: https://codereview.chromium.org/808563003 git-svn-id: svn://svn.chromium.org/blink/trunk@187186 bbb929c8-8fbe-4397-9dbb-9b2b20218538

id:20001 of https://codereview.chromium.org/780743002/) Reason for revert: Caused bug 442454 BUG=442454 Original issue's description: > Formalize object insertion sequence: RenderInline > > Similar to https://codereview.chromium.org/753643003 (for RenderBlock), > but for RenderInline. > > Modifies RenderInline::splitInlines() so that any child is always added > into a *rooted* tree during execution of the function. > > Please see the RenderBlock change for more details. > > BUG=365897 > TEST=Existing tests (no visible behavior change) > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186863 TBR=jchaffraix@chromium.org,dsinclair@chromium.org NOTREECHECKS=true NOTRY=true BUG=365897 Review URL: https://codereview.chromium.org/807003002 git-svn-id: svn://svn.chromium.org/blink/trunk@187196 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r187161 was not the culprit of the build failure. > Revert of IDL: Properly support [Exposed] on static methods (patchset #2 id:20001 of https://codereview.chromium.org/793243004/) > > Reason for revert: > seems to be causing compile failures: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/101401/steps/compile/logs/stdio > > Original issue's description: > > IDL: Properly support [Exposed] on static methods > > > > They were conditionally installed as indicated by the [Exposed] attribute, > > but they were installed on the prototype object rather than on the > > interface object. > > > > A static method with [Exposed] fulfills the requirements for being treated > > both as a conditionally enabled method (because of [Exposed]) and a method > > with custom registration (because of being static), and due to the order > > in which those requirements were checked, it ended up being treated as a > > conditionally enabled method, only. > > > > Fix by giving custom registration priority and by adding the same > > condition filters around that registration code, so that such methods can > > still also be all sorts of conditionally enabled. > > > > BUG=434741 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187161 > > TBR=haraken@chromium.org,jl@opera.com > NOTREECHECKS=true > NOTRY=true > BUG=434741 > > Review URL: https://codereview.chromium.org/806773006 TBR=samuong@chromium.org Review URL: https://codereview.chromium.org/806683004 git-svn-id: svn://svn.chromium.org/blink/trunk@187228 bbb929c8-8fbe-4397-9dbb-9b2b20218538

id:20001 of https://codereview.chromium.org/806823002/) Reason for revert: Broke the Win 7 Tests builder: http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests Example build failure: http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/7521 Two content_browser tests tests failing: https://chromium.googlesource.com/chromium/src/+/master/content/test/data/accessibility/aria-menuitemcheckbox.html https://chromium.googlesource.com/chromium/src/+/master/content/test/data/accessibility/aria-menuitemradio.html Original issue's description: > Ignore text elements for menu item related roles. > > Text elements should go along with menu item related roles. > Let's consider this example: <div role="menuitemcheckbox" tabindex="0">menu item checkbox</div> > Currently MenuItemCheckBoxRole is represented by accessible object and its title is the second > accessible object. Expected behavior is that we should have just one accessible object. > > BUG=442278 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187323 TBR=dmazzoni@chromium.org,k.czech@samsung.com NOTREECHECKS=true NOTRY=true BUG=442278 Review URL: https://codereview.chromium.org/796223003 git-svn-id: svn://svn.chromium.org/blink/trunk@187355 bbb929c8-8fbe-4397-9dbb-9b2b20218538

#2 id:20001 of https://codereview.chromium.org/812243004/) Reason for revert: This causes content_browsertests failures: DumpAccessibilityTreeTest.AccessibilityCaption http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/17483/steps/content_browsertests%20%28with%20patch%29/logs/AccessibilityCaption Original issue's description: > TableCaptionElement is not exposed to accessibility > > Adding caption element to accessibility tree. > > BUG=443970 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187641 TBR=dmazzoni@chromium.org,aboxhall@chromium.org,ramya.v@samsung.com NOTREECHECKS=true NOTRY=true BUG=443970 Review URL: https://codereview.chromium.org/811963003 git-svn-id: svn://svn.chromium.org/blink/trunk@187664 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…ired (patchset #1 id:1 of https://codereview.chromium.org/823773003/) Reason for revert: Makes ASAN bots red. STDERR: ==8== WARNING: MemorySanitizer: use-of-uninitialized-value STDERR: #0 0x7f4ebe7c540e in blink::DOMTimer::fired() third_party/WebKit/Source/core/frame/DOMTimer.cpp:168:9 STDERR: #1 0x7f4ec5bc8b4c in blink::ThreadTimers::sharedTimerFiredInternal() third_party/WebKit/Source/platform/ThreadTimers.cpp:137:9 STDERR: #2 0x7f4ec5bc7fef in blink::ThreadTimers::sharedTimerFired() third_party/WebKit/Source/platform/ThreadTimers.cpp:107:5 STDERR: #3 0x7f4ec451bae7 in Run base/callback.h:396:12 STDERR: #4 0x7f4ec451bae7 in base::Timer::RunScheduledTask() base/timer/timer.cc:211:0 Original issue's description: > Oilpan: Remove redundant LifecycleObserver from DOMTimer::fired > > It is redundant to create a LifecycleObserver in DOMTimer::fired, because DOMTimer is an ActiveDOMObject and thus it can just peek executionContext() to know whether its associated ExecutionContext is already gone or not. > > BUG=340522 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187649 NOTRY=true TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com,haraken@chromium.org BUG=340522 Review URL: https://codereview.chromium.org/821313002 git-svn-id: svn://svn.chromium.org/blink/trunk@187668 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…nwjs#2 id:20001 of https://codereview.chromium.org/1053263002/) Reason for revert: This is causing failures with webkit_unit_tests on various chromium.webkit builders. Original issue's description: > Update Subresource Integrity parsing to new format > > This is a recommit of https://codereview.chromium.org/1047403002/. > > The latest version of the spec has eliminated the ni:/// prefix and > moved the (optional) MIME type to the front of the integrity attribute. > This updates the parsing to reflect these changes as well as all of the > associated tests. > > TBR=mkwst@chromium.org > BUG=471429 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193386 TBR=mkwst@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=471429 Review URL: https://codereview.chromium.org/1071793002 git-svn-id: svn://svn.chromium.org/blink/trunk@193394 bbb929c8-8fbe-4397-9dbb-9b2b20218538

… id:20001 of https://codereview.chromium.org/1048003002/) Reason for revert: Helper systems detected nothing: remove this test. Original issue's description: > Add a multiple image decode http layout test > > Not enabled for run-webkit-tests (marked [Skip] in TestExpectations) but > used in helper systems that wrap run-webkit-tests. Test is dumpAsText(), > which allows random selection of the test image. Images are served after > a short pause to jitter network packet delivery. > > TBR=inferno@chromium.org > BUG=398235 > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192900 TBR=inferno@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=398235 Review URL: https://codereview.chromium.org/1102213002 git-svn-id: svn://svn.chromium.org/blink/trunk@194484 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…wjs#2 id:20001 of https://codereview.chromium.org/1055193004/) Reason for revert: Broke content_browsertests, preventing Blink from rolling. 3 tests failed: DevToolsAgentTest.DevToolsResumeOnClose V8SamplingProfilerTest.V8SamplingJitCodeEventsCollected V8SamplingProfilerTest.V8SamplingSamplesCollected See, for example: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/60276 Original issue's description: > Oilpan: Enable lazy sweeping on non-oilpan builds > > Currently lazy sweeping is enabled only on oilpan builds. Since the lazy sweeping has been stable on the oilpan builds for >3 months, I think it's now safe to enable it on non-oilpan builds as well. > > BUG=480837 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194808 TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com,haraken@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480837 Review URL: https://codereview.chromium.org/1123443002 git-svn-id: svn://svn.chromium.org/blink/trunk@194812 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…wjs#2 id:20001 of https://codereview.chromium.org/1055193004/) Reason for revert: The use of lazy sweeping appears to be behind this ASan regression, https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_ASAN/18437/layout-test-results/http/tests/serviceworker/fetch-canvas-tainting-crash-log.txt i.e., it risks lifecycle notification touching already finalized & freed objects. Original issue's description: > Oilpan: Enable lazy sweeping on non-oilpan builds > > Currently lazy sweeping is enabled only on oilpan builds. Since the lazy sweeping has been stable on the oilpan builds for >3 months, I think it's now safe to enable it on non-oilpan builds as well. > > BUG=480837 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194808 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195022 TBR=oilpan-reviews@chromium.org,haraken@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480837 Review URL: https://codereview.chromium.org/1133563004 git-svn-id: svn://svn.chromium.org/blink/trunk@195067 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…:20001 of https://codereview.chromium.org/1135753002/) Reason for revert: The v8 use counters now being handled are reported over an Isolate for which callingExecutionContext() fails -- https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac_Oilpan__dbg_/9995/layout-test-results/results.html (first build on Mac Oilpan(dbg) with the new crashes.) Original issue's description: > Add support for new-ish V8 use counters > > R=jochen@chromium.org > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195119 TBR=jochen@chromium.org,erikcorry@chromium.org,erik.corry@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1131413002 git-svn-id: svn://svn.chromium.org/blink/trunk@195151 bbb929c8-8fbe-4397-9dbb-9b2b20218538

… of https://codereview.chromium.org/1123313004/) Reason for revert: This is causing a reliable failure in the chromevox_unittests on the Linu ChromeOS Tests (1) bot: https://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/13831 (and is also blocking the Blink roll because of the failure) Original issue's description: > Handles AX role for time element. > > This patch adds InputTimeRole and makes it be used for Input element > with time type. In order to handle Time element for AX, the current > TimeRole is used. > > BUG=480861 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195168 TBR=dmazzoni@chromium.org,je_julie.kim@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480861 Review URL: https://codereview.chromium.org/1134103002 git-svn-id: svn://svn.chromium.org/blink/trunk@195188 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…wjs#2 id:20001 of https://codereview.chromium.org/1138743002/) Reason for revert: The patch seems to be causing preconnect related crashes: https://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/13855 Reverting until I get a clearer picture as to why that is the case. Original issue's description: > Added <link rel=preconnect> crossorigin attribute > > In order to support preconnect for both anonymous and non-anonymous connection pools we need to add support for the crossorigin attribute in <link rel=preconnect>. > This CL implements the core functionality of this change on the Blink side. > > BUG=468005 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195184 TBR=mkwst@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=468005 Review URL: https://codereview.chromium.org/1131513004 git-svn-id: svn://svn.chromium.org/blink/trunk@195200 bbb929c8-8fbe-4397-9dbb-9b2b20218538

…h renaming tmp file (patchset nwjs#2 id:20001 of https://codereview.chromium.org/1130933003/) Reason for revert: This change breaks two things: (1) hard link-based debug_devtools workflow (I have a fix for it). (2) it resets file permissions Original issue's description: > DevTools: [Workspace] implement setting file content through renaming tmp file > > ATM setFileContent is implemented via two consecutive calls: > - truncate(0) > - write(newContent) > > Both operations are not atomic; this results in user data corruption. > > This patch implements setFileContent through tmp file: > - create temp file (original file name + ".tmp") > - write into temp file > - rename temp file into current file > > As file renaming is atomic, this way we avoid data loss. > > BUG=485983 > R=pfeldman_slow > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195311 TBR=lushnikov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=485983 Review URL: https://codereview.chromium.org/1132243007 git-svn-id: svn://svn.chromium.org/blink/trunk@195385 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix debug build for nw0.8

93af34a

Back port a patch from 4dabdca to fix the debug build of 0.8 branch.

rogerwang added a commit that referenced this pull request May 17, 2014

Merge pull request #2 from libm/libm_nw0.8

bd3b52c

Fix debug build for nw0.8

rogerwang merged commit bd3b52c into nwjs:nw0.8 May 17, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix debug build for nw0.8 #2

Fix debug build for nw0.8 #2

libm commented Apr 30, 2014

rogerwang commented Apr 30, 2014

libm commented May 7, 2014

Fix debug build for nw0.8 #2

Fix debug build for nw0.8 #2

Conversation

libm commented Apr 30, 2014

rogerwang commented Apr 30, 2014

libm commented May 7, 2014