Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transparency] [WIN] force refresh/redraw on transparency changes #7

Merged
merged 2 commits into from
Nov 22, 2014

Conversation

jtg-gg
Copy link
Member

@jtg-gg jtg-gg commented Nov 18, 2014

No description provided.

rogerwang added a commit that referenced this pull request Nov 22, 2014
[Transparency] [WIN] force refresh/redraw on transparency changes
@rogerwang rogerwang merged commit 49872e2 into nwjs:nw Nov 22, 2014
rogerwang added a commit that referenced this pull request Mar 5, 2015
or debug callback can't get the listener.
Fix nwjs/nw.js#719

#0  WebCore::InspectorDebuggerAgent::didPause (this=0x7ffff7ee8800,
    scriptState=0x192e07eebb10, callFrames=..., exception=...)
    at ../../third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp:682
#1  0x0000000003665f7e in WebCore::ScriptDebugServer::breakProgram (
    this=0x7ffff7ee8260, executionState=..., exception=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:425
#2  0x0000000003666ceb in WebCore::ScriptDebugServer::handleV8DebugEvent (
    this=0x7ffff7ee8260, eventDetails=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:503
#3  0x0000000003666012 in WebCore::ScriptDebugServer::v8DebugEventCallback (
    eventDetails=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:435
#4  0x0000000000f7ecb3 in v8::internal::Debugger::CallCEventCallback (
    this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=...,
    client_data=0x0) at ../../v8/src/debug.cc:2953
#5  0x0000000000f7ebf9 in v8::internal::Debugger::CallEventCallback (
    this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=...,
    client_data=0x0) at ../../v8/src/debug.cc:2932
#6  0x0000000000f7eabd in v8::internal::Debugger::ProcessDebugEvent (
    this=0x7ffff7eec520, event=v8::Break, event_data=..., auto_continue=false)
    at ../../v8/src/debug.cc:2909
#7  0x0000000000f7e24d in v8::internal::Debugger::OnDebugBreak (
    this=0x7ffff7eec520, break_points_hit=..., auto_continue=false)
    at ../../v8/src/debug.cc:2750
#8  0x0000000000f7836f in v8::internal::Debug::Break (this=0x7ffff7eecc20,
    args=...) at ../../v8/src/debug.cc:992
#9  0x0000000000f787a8 in v8::internal::__RT_impl_Debug_Break (args=...,
    isolate=0x7ffff7e80020) at ../../v8/src/debug.cc:1062
#10 0x0000000000f78769 in v8::internal::Debug_Break (args_length=0,
    args_object=0x7fffffff8248, isolate=0x7ffff7e80020)
    at ../../v8/src/debug.cc:1061
jtg-gg pushed a commit to jtg-gg/blink that referenced this pull request Jul 31, 2015
…MString (patchset nwjs#7 id:120001 of https://codereview.chromium.org/871013007/)

Reason for revert:
Failing in gtests:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8/builds/35898/steps/webkit_unit_tests/logs/DOMWebSocketDeathTest.binaryType

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 5 threads.
../../third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp:687: Failure
Death test: m_websocket->setBinaryType("hoge")
    Result: failed to die.
 Error msg:
[  DEATH   ]
[  FAILED  ] DOMWebSocketDeathTest.binaryType (5 ms)


Original issue's description:
> This addresses a FIXME in WebSocket.idl
> 
> Also removing logging for wrong value as now we are logging in binding code:
> https://codereview.chromium.org/955413002/.
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193201

TBR=habib.virji@samsung.com,nbarth@chromium.org,yutak@chromium.org,tyoshino@chromium.org,haraken@chromium.org,bashi@chromium.org,paritosh.in@samsung.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1053013006

git-svn-id: svn://svn.chromium.org/blink/trunk@193206 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg pushed a commit to jtg-gg/blink that referenced this pull request Jul 31, 2015
…hset nwjs#7 id:120001 of https://codereview.chromium.org/1108753002/)

Reason for revert:
Speculative revert due to chromium ASAN failure on try bots:
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/60807/steps/components_browsertests%20%28with%20patch%29/logs/PasswordFormConversionUtilsTest.BasicFormAttributes

Original issue's description:
> Migrate classes under fetch/ to Oilpan heap.
> Resource and its sub-classes are kept as WillBe style,
> because they are not handled well. (It is another issue.)
> 
> BUG=479467
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194707

TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com,haraken@chromium.org,peria@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=479467

Review URL: https://codereview.chromium.org/1120643002

git-svn-id: svn://svn.chromium.org/blink/trunk@194740 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants