Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed minHeight and maxHeight calculation on Windows #51

Open
wants to merge 2 commits into
base: nw14
Choose a base branch
from
Open

Fixed minHeight and maxHeight calculation on Windows #51

wants to merge 2 commits into from

Conversation

ghostoy
Copy link
Member

@ghostoy ghostoy commented Nov 7, 2016 •
edited
Loading

backport for nw14

fixed nwjs/nw.js#5407

rogerwang pushed a commit that referenced this pull request Dec 5, 2016
@tdanderson
Fix button-pressed handling in ImeDetailedView
fe09ab9 
ImeDetailedView::HandleButtonPressed() now calls up to
its superclass ImeListView::HandleButtonPressed() in
order to handle clicks on the VK toggle button.

BUG=657146
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2513713002
Cr-Commit-Position: refs/heads/master@{#433076}
(cherry picked from commit 6a7e15b)

Review URL: https://codereview.chromium.org/2518963004 .

Cr-Commit-Position: refs/branch-heads/2924@{#51}
Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech pushed a commit that referenced this pull request Jan 29, 2017
[Merge M57] Fix import legacy, pref based pins.
9329198 
This CL contains 2 fixes for importing legacy pref based pins.
1. Import may happen at the moment when profile is not synced yet and
in last case it does not actually contain information from previous
bulds.
2. Importing ignores apps that currently are not installed. This
leads to situation that we loose pin information for such apps
and in case apps are installed later they do not appear pinned.
Solution is to import all existings apps in prefs.

BUG=680821
TEST=Clearn app sync server data. Login on M52 and do some pinning.
     Next login on M55 and pin additional app. Next login to ToT
     and observe that pin is restored for existing apps and
     pins appear automatically once apps are installed later.
TBR=stevenjb@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2646973003
Cr-Commit-Position: refs/heads/master@{#445398}
(cherry picked from commit d8cc9d2)

Review-Url: https://codereview.chromium.org/2655553002
Cr-Commit-Position: refs/branch-heads/2987@{#51}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
[Merge M58] arc: Handle position conflict in app list items.
651a2d0 
It is not guaranteed that sync items have unique positions. This may
cause crash in case web store app has conflicting pos with some other
app.

TEST=Unit test added
BUG=692802

NOTRY=true
NOPRESUBMIT=true
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2732633003
Cr-Commit-Position: refs/heads/master@{#455195}
(cherry picked from commit 11f9ee6)

Review-Url: https://codereview.chromium.org/2740603002
Cr-Commit-Position: refs/branch-heads/3029@{#51}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
Record more download resumption UMAs to analyze the how download is r…
a74d022 
…esumed

This CL adds the metrics to study how many resumption is attempted for a download.
This allows us to study the high download interruption counts.
And choose a better throttling strategy.

BUG=712318
TBR=dtrainor@chromium.org, isherman@chromium.org

Review-Url: https://codereview.chromium.org/2820193002
Cr-Commit-Position: refs/heads/master@{#465451}
(cherry picked from commit bbe9ad7)

Review-Url: https://codereview.chromium.org/2831603003 .
Cr-Commit-Position: refs/branch-heads/3071@{#51}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
ChromeOS OOBE: update HID detection screen icons to SVG.
21257d2 
TBR=alemate@chromium.org

(cherry picked from commit 6c33b71)

Bug: 747138
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I77e1b33f74f91e5918d9a74f9a79cd8b0de79fc6
Reviewed-on: https://chromium-review.googlesource.com/580675
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488794}
Reviewed-on: https://chromium-review.googlesource.com/585676
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#51}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
[Merge to M62] Default (unset by admin) migration policy for EDU
52f8877 
If the admin left the policy for migration unset and the device is
enrolled in an EDU domain, the server will send to the client
kAskForEcryptfsArcUsers = 5 value for that policy.

When the client receives the kAskForEcryptfsArcUsers policy value,
it must check two things:
1. If the device had ARC M in M60 (specified by the flag
kArcTransitionMigrationRequired)
2. Arc is enabled by poicy.

If both conditions apply, then user should be asked if the migration
has to be performed. Otherwise the migration is disabled for this
policy value.

This CL was originally owned by igorcov@ and tracked in CL:645352.

BUG=747907
TEST=Manual, unit_tests --gtest_filter=ArcMigration*
TBR=pmarko@chromium.org

(cherry picked from commit 3c98b1d)

Change-Id: I668e5d4e33afa94607aa6db790c06e6f9ee61879
Reviewed-on: https://chromium-review.googlesource.com/645953
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499237}
Reviewed-on: https://chromium-review.googlesource.com/653638
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#51}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
Change assign to copy for block property
a80e60e 
RecentTabsHandsetCoordinator should retain its block property.

Bug: 775508
Change-Id: Ifd9bd829786592adde9057bec68bf3a73b6c9fc2
Reviewed-on: https://chromium-review.googlesource.com/723304
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509383}(cherry picked from commit 51058e6)
Reviewed-on: https://chromium-review.googlesource.com/726119
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#51}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
@stevenjb
Fix network config UI
4a5646e 
This CL cleans up the network config UI to improve the display
of 'Connecting' and improve error handling and display.

TBR=stevenjb@chromium.org

(cherry picked from commit a9bc09d)

Bug: 795715, 795698
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2f2dc1654c29524e5b7ae99cfbe43692a9fdb470
Reviewed-on: https://chromium-review.googlesource.com/874605
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530967}
Reviewed-on: https://chromium-review.googlesource.com/882550
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#51}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
Incrementing VERSION to 66.0.3359.14
d5f66d3 
TBR=dimu@chromium.org

Change-Id: I218f8ac4f73dc0c0592f664b68904b01ae1c13a2
Reviewed-on: https://chromium-review.googlesource.com/952323
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#51}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
[Merge to M67]Cancel the ongoing animation for repeat power button re…
ad7ddfe 
…leases.

TBR=minch@chromium.org

Should cancel the stated showing menu animation for repeat power button
releases. Otherwise, the ongoing animation will run the callback function
SetShowMenuAnimationDone to start |pre_shutdown_timer_|
OnImplicitAnimationFinished after release the power button. This will lead
to device power off.

(cherry picked from commit 1e39dd5)

Bug: 831915
Change-Id: I07753f4156dfc7ba299c37f8fd7a7551d5ec858a
Reviewed-on: https://chromium-review.googlesource.com/1009485
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550509}
Reviewed-on: https://chromium-review.googlesource.com/1015419
Reviewed-by: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#51}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
Download location: Fix issue for location dialog prompt pref.
b828621 
When users choose not to prompt the download location dialog. We still
prompt the dialog. This is caused by two reasons:

1. The pref is persisted when user click the download button. Instead,
the pref should also be persisted when users click on the checkbox.

2. When exisiting file results in file name conflict, we didn't check
the pref.

TBR=xingliu@chromium.org

(cherry picked from commit f865da8)

Bug: 845311
Change-Id: I8a3bf53cbb9edcd5905003b5739400243977e55a
Reviewed-on: https://chromium-review.googlesource.com/1074378
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562558}
Reviewed-on: https://chromium-review.googlesource.com/1080037
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#51}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
Use the Native Certificate Viewer on MacOS even on MacViews
5d64a46 
BUG=766926

Change-Id: I6d0302763687bbb4fe30682684ad85a2ac79f782
Reviewed-on: https://chromium-review.googlesource.com/1145674
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577201}(cherry picked from commit 7fbbd5f)
Reviewed-on: https://chromium-review.googlesource.com/1148610
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#51}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
@SergeyUlanov
Reland "Cleanup lifetime handling in P2P sockets."
fb71399 
This is a reland of e6df634

Original change's description:
> Cleanup lifetime handling in P2P sockets.
>
> Several fixes for P2P sockets:
>  1. P2PSocketTcpBase no longer posts tasks with base::Unretained().
>  2. Previously P2P sockets were destroyed only in response to Mojo
>     interfaces errors. They were not destroyed on other error. Fixed
>     it now.
>  3. Simplified TCP server socket protocol. Now the accepted socket is
>     passed directly in IncomingTcpConnection.
>  4. Updated unittests to verify that P2P sockets are destroyed in
>     response to errors.
>  5. Other minor cleanups, particularly moved packet dump logic to
>     SocketManager and removed some unittests that are not relevant
>     after migration to mojo.
>
> Bug: 877515,  877514
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: I55276e372185c558667289a1efdfcf0421c3d7bc
> Reviewed-on: https://chromium-review.googlesource.com/1189083
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588430}

TBR=jam@chromium.org,wfh@chromium.org

Bug: 877515, 877514,880218
Change-Id: I0cc79616b70f7900e6c551a7c91e404de2fb7dd3
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1206338
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588887}(cherry picked from commit e07f397)
Reviewed-on: https://chromium-review.googlesource.com/1207091
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#51}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
@yukidmy @yuki3
Create v8::HandleScope in JSBasedEventListener::GetSourceLocation()
23eaedb 
This is the bug fixing for previous CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1253317

v8::HandleScope was not named.

Bug: 894069
Change-Id: Ib9111275bad434b1968a4bd674a0b8932b8c1533
Reviewed-on: https://chromium-review.googlesource.com/c/1278548
Commit-Queue: Yuki Yamada <yukiy@google.com>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599110}(cherry picked from commit f93617e)
Reviewed-on: https://chromium-review.googlesource.com/c/1283751
Cr-Commit-Position: refs/branch-heads/3578@{#51}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
@dalecurtis
Merge M72: "Cleanup comments and interfaces for AudioRendererMixer+In…
cdd5484 
…put."

Some cleanups I noticed while working on adding the async callback;
does the following:

- Fixes some spelling errors.
- Removes the need to save a callback to subscribe for errors.
- Removes a stale comment associated with the error callbcks.
- Removes some unused methods from the ARM interface.
- Always posts the OutputDeviceInfoCB per documented contract.
- Switches to "using", "RepeatingCallback", etc where appropriate.
- Switches to base::flat_set/map where appropriate.

BUG=905506
TEST=existing tests all pass.

Change-Id: Ib670c04ed59b98b07c18cc3f3afac44d802a2a68
Reviewed-on: https://chromium-review.googlesource.com/c/1357540
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613731}(cherry picked from commit 3b3f55b)
Reviewed-on: https://chromium-review.googlesource.com/c/1362216
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#51}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
Enable Zero State by default.
3a68da0 
Bug: 924785
Change-Id: Ia077d4d43baf974df46baa64632254e95a9ec6b1
Reviewed-on: https://chromium-review.googlesource.com/c/1432883
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#626176}(cherry picked from commit 237240f)
Reviewed-on: https://chromium-review.googlesource.com/c/1443993
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#51}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
Incrementing VERSION to 74.0.3729.7
8df72e3 
TBR=govind@chromium.org

Change-Id: I70b467d370f00a3952251553da15ad63281b0946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518829
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3729@{#51}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghostoy @rogerwang