-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outline and destructive button large components #48
Conversation
Don't know how to test out if my inactive buttons work yet 👀 |
Jae Wu's PR https://github.com/nwplus/Aurora/pull/43/files has the props for whether a button is active or not. You can either wait for his to merge or if you don't want to wait, copy his code in Button.stories and do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to use color constants in your PR. Otherwise everything looks good. You can import colors by
import { colors } from "../colors/index";
and using colors like this:
color: ${colors.teal600};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done refactoring the component! This looks good to me.
No description provided.