Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline and destructive button large components #48

Merged
merged 9 commits into from
Jul 10, 2022

Conversation

DonaldKLee
Copy link
Member

No description provided.

@DonaldKLee
Copy link
Member Author

Don't know how to test out if my inactive buttons work yet 👀

@DonaldKLee DonaldKLee linked an issue Jun 25, 2022 that may be closed by this pull request
@ajo01
Copy link
Contributor

ajo01 commented Jun 25, 2022

Jae Wu's PR https://github.com/nwplus/Aurora/pull/43/files has the props for whether a button is active or not. You can either wait for his to merge or if you don't want to wait, copy his code in Button.stories and do
if (!props.active) { getInactiveStyles() } in the Button component.

src/components/button/Button.js Outdated Show resolved Hide resolved
src/components/button/Button.js Outdated Show resolved Hide resolved
src/components/button/Button.js Outdated Show resolved Hide resolved
Copy link
Contributor

@ajo01 ajo01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to use color constants in your PR. Otherwise everything looks good. You can import colors by
import { colors } from "../colors/index";
and using colors like this:
color: ${colors.teal600};

@DonaldKLee DonaldKLee requested a review from ajo01 July 5, 2022 03:49
src/components/button/ButtonCSS.js Outdated Show resolved Hide resolved
src/components/button/ButtonCSS.js Outdated Show resolved Hide resolved
src/components/button/ButtonCSS.js Outdated Show resolved Hide resolved
src/components/button/ButtonCSS.js Outdated Show resolved Hide resolved
@DonaldKLee DonaldKLee requested a review from ajo01 July 9, 2022 07:26
Copy link
Contributor

@ajo01 ajo01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done refactoring the component! This looks good to me.

@ajo01 ajo01 requested review from dchen150 and removed request for dchen150 July 10, 2022 04:19
@ajo01 ajo01 dismissed dchen150’s stale review July 10, 2022 04:21

Appropriate changes have been made

@ajo01 ajo01 merged commit 13dd256 into main Jul 10, 2022
@ajo01 ajo01 deleted the Outline-and-Destructive-ButtonLarge-Components branch July 10, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outline and Destructive ButtonLarge Components
5 participants