Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 290 171 282 update #296

Closed
wants to merge 9 commits into from

Conversation

hamzeee9
Copy link

Of course, here's the message translated into English:

Hello everyone,

My friend and I are students at HTW Hochschule Berlin, and as part of our Software Engineering course, we have been tasked with fixing issues in an open-source project. We chose the nxengine-evo project and successfully resolved the following three issues:

Keyboard controls don't work (#290)
Add separate gamepad controls section (suggestion/Feature Request) (#282)
HiDPI resolution options (#171)
We are excited to share our changes with you and the community. Thank you for the opportunity to contribute to this great project!

Best regards,

@isage
Copy link
Collaborator

isage commented Jun 14, 2024

  1. this is broken (see CI run)
  2. this is impossible to review, as it changes formatting in many unrelated places
  3. comments should be in english
  4. each issue solution should be split into separate PR

@isage isage closed this Jun 14, 2024
@xordspar0
Copy link
Contributor

Hello! That sounds like a cool assignment. Is this your first time contributing to an open source project? I'm just a random guy on the Internet and I'm not affiliated with this project in any way, so you don't have to listen to me. But I do have some advice that I like to give new contributors. Besides what isage already said:

  1. It's normal during the feedback process for project maintainers to ask you to change things. Sometimes you will have to make many revisions before a change is accepted. Be patient and keep trying.
  2. Respond to review comments promptly. Most project maintainers are volunteers that work on their projects in their free time. It takes significant time to read, understand, and review a pull request. If you respond to review comments quickly, your PR will likely be accepted quickly. However, if you wait a long time before responding, the reviewer will forget about your PR and will need to read and understand it all over again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants