-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local webhook testing support #399
Merged
mrashed-dev
merged 23 commits into
main
from
TW-1786-ruby-release-minor-version-with-webhook-feature
Feb 2, 2023
Merged
Local webhook testing support #399
mrashed-dev
merged 23 commits into
main
from
TW-1786-ruby-release-minor-version-with-webhook-feature
Feb 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for quickly spinning up a websocket connection to test Nylas webhook events locally
Setting up the websocket client requires a lot of lines, and to conform with the rules set up for rubocop, it would result in many small methods that will result in less readable code.
mrashed-dev
changed the title
Tw 1786 ruby release minor version with webhook feature
Local webhook testing support
Jan 31, 2023
Codecov Report
@@ Coverage Diff @@
## main #399 +/- ##
==========================================
+ Coverage 97.73% 97.83% +0.09%
==========================================
Files 126 128 +2
Lines 4555 4712 +157
==========================================
+ Hits 4452 4610 +158
+ Misses 103 102 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
quzhi1
approved these changes
Feb 2, 2023
agtang96
approved these changes
Feb 2, 2023
mrashed-dev
deleted the
TW-1786-ruby-release-minor-version-with-webhook-feature
branch
February 2, 2023 20:24
Merged
mrashed-dev
added a commit
that referenced
this pull request
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables support for local webhook development. When implementing this feature in your app, the SDK will create a tunnel connection to a websocket server and registers it as a webhook callback to your Nylas account.
Usage
During the setup process you can pass in methods to override the websocket client's callback methods. The most important method is the
on_message
method which returns a parsed delta event from the webhook server.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.