Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local webhook testing support #399

Merged

Conversation

mrashed-dev
Copy link
Contributor

@mrashed-dev mrashed-dev commented Jan 31, 2023

Description

This PR enables support for local webhook development. When implementing this feature in your app, the SDK will create a tunnel connection to a websocket server and registers it as a webhook callback to your Nylas account.

Usage

During the setup process you can pass in methods to override the websocket client's callback methods. The most important method is the on_message method which returns a parsed delta event from the webhook server.

nylas = Nylas::API.new(
    app_id: CLIENT_ID,
    app_secret: CLIENT_SECRET
)

# Define the callback for the on_message event
def on_message(delta)
  if delta.type == Nylas::WebhookTrigger::MESSAGE_UPDATED
    p [:delta, delta]
  end
end

# Config that sets the region, triggers, and callbacks
config = {
  "region": "us",
  "triggers": [WebhookTrigger::MESSAGE_UPDATED],
  "on_message": method(:on_message)
}

# Create, register, and open the webhook tunnel for testing
Nylas::Tunnel::open_webhook_tunnel(nylas, config)

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

This commit adds support for quickly spinning up a websocket connection to test Nylas webhook events locally
Setting up the websocket client requires a lot of lines, and to conform with the rules set up for rubocop, it would result in many small methods that will result in less readable code.
@mrashed-dev mrashed-dev changed the title Tw 1786 ruby release minor version with webhook feature Local webhook testing support Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #399 (f970ce4) into main (b3b7a04) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
+ Coverage   97.73%   97.83%   +0.09%     
==========================================
  Files         126      128       +2     
  Lines        4555     4712     +157     
==========================================
+ Hits         4452     4610     +158     
+ Misses        103      102       -1     
Impacted Files Coverage Δ
lib/nylas.rb 100.00% <100.00%> (ø)
lib/nylas/services/tunnel.rb 100.00% <100.00%> (ø)
spec/nylas/tunnel_spec.rb 100.00% <100.00%> (ø)
lib/nylas/collection.rb 86.58% <0.00%> (+1.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mrashed-dev mrashed-dev marked this pull request as ready for review February 2, 2023 19:42
@mrashed-dev mrashed-dev merged commit 22c591b into main Feb 2, 2023
@mrashed-dev mrashed-dev deleted the TW-1786-ruby-release-minor-version-with-webhook-feature branch February 2, 2023 20:24
@mrashed-dev mrashed-dev mentioned this pull request Feb 2, 2023
mrashed-dev added a commit that referenced this pull request Feb 2, 2023
New Nylas Ruby SDK v5.15.0 release brings the following additions:
* Add local webhook testing support (#399)
* Add `tzinfo`, `faye-websocket`, `eventmachine` as runtime dependencies (#401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants