Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tzinfo as a runtime dependency #401

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Add tzinfo as a runtime dependency #401

merged 4 commits into from
Feb 2, 2023

Conversation

mrashed-dev
Copy link
Contributor

@mrashed-dev mrashed-dev commented Feb 2, 2023

Description

This PR adds tzinfo as a runtime dependency as it is used by Nylas::When, as well as faye-websockets and eventmachine as used by Nylas::Tunnel.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #401 (24de1d8) into main (22c591b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files         128      128           
  Lines        4712     4712           
=======================================
  Hits         4610     4610           
  Misses        102      102           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mrashed-dev mrashed-dev merged commit de03f7a into main Feb 2, 2023
@mrashed-dev mrashed-dev deleted the add-tzinfo-dep branch February 2, 2023 20:55
@mrashed-dev mrashed-dev mentioned this pull request Feb 2, 2023
mrashed-dev added a commit that referenced this pull request Feb 2, 2023
New Nylas Ruby SDK v5.15.0 release brings the following additions:
* Add local webhook testing support (#399)
* Add `tzinfo`, `faye-websocket`, `eventmachine` as runtime dependencies (#401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants