Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/circulating supply #2814

Merged
merged 59 commits into from
Jan 12, 2023
Merged

Feature/circulating supply #2814

merged 59 commits into from
Jan 12, 2023

Conversation

jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented Jan 10, 2023 •
edited
Loading

Description

Closes: #1902

note: to test it, you need to make sure vesting contract with this change: #2778 is deployed

further note that until Alexis says otherwise, the endpoint should be probably disabled. Do to it, add the following lines to config.toml file:

[circulating_supply_cacher]

enabled = false

Checklist:

  • added a changelog entry to CHANGELOG.md

@jstuczyn jstuczyn marked this pull request as ready for review January 11, 2023 15:05
@futurechimp @jstuczyn
Fixed typo in node_status_cache constant
93b5a91
@futurechimp @jstuczyn
ibid
e2467fa
@futurechimp @jstuczyn
Moved some caching stuff around so I can see what depends on what
c2026c5
@futurechimp @jstuczyn
Finishing merge of conflicted files
e9228a1
@futurechimp @jstuczyn
Minor smoothing
7c77dd4
@futurechimp @jstuczyn
Got cache reads working for circ supply and refactored common cache
6db5dec
@futurechimp @jstuczyn
Refactored nyxd client usages to make things bit more clear
f19d395
@futurechimp @jstuczyn
Moved caching support stuff into the support folder
3072fec
@futurechimp @jstuczyn
Moved storage code into support module
2da7e44
@futurechimp @jstuczyn
Removed dead code
1c655a8
@futurechimp @jstuczyn
Tweaks
6955ab4
@futurechimp @jstuczyn
Handling cases a little more nicely in circulating supply api
70b457a
@futurechimp @jstuczyn
Renamed nymd_client to nyxd_client
fd990ad
@futurechimp @jstuczyn
Pulled CacheNotification into the caching support module
c0020f5
@futurechimp @jstuczyn
Pulled some domain-specific helpers out of cache refresher
cd7239d
@futurechimp @jstuczyn
Moving some more helper methods out of the cache refresher
f5cb7f1
@futurechimp @jstuczyn
Deleting unused code
df68a41
@futurechimp @jstuczyn
Extracted a few more functions out of the cache refresher
a4c14b0
@futurechimp @jstuczyn
A few comments as breadcrumbs
8da5680
@futurechimp @jstuczyn
Renaming the anemic "helpers" to "node_sets"
0830768
@futurechimp @jstuczyn
Renaming the validator_cache module to nym_contract_cache
bd409d3
@futurechimp @jstuczyn
Renaming nym contract cache stuff to make things clearer
90805dc
@futurechimp @jstuczyn
Renamging a few things in comments
b1b89bc
@futurechimp @jstuczyn
Renaming validator_cache to nym_contract_cache
ef67968
@futurechimp @jstuczyn
foomp
64a4e4b
futurechimp and others added 24 commits January 11, 2023 15:35
@futurechimp @jstuczyn
Circulating supply cache now working with simple logic
710adf4
@futurechimp @jstuczyn
Fixed up circulating supply method names
04ad46e
@futurechimp @jstuczyn
Starting to work in some (wrong) constants
eaf4c03
@futurechimp @jstuczyn
Documented the cache
4a0d42d
@futurechimp @jstuczyn
Renaming circulating-supply route
1bb91df
@jstuczyn
nym-api compiling after the rebasing
8b1d924 
but most likely not fully working yet
@jstuczyn
removed unused imports
6263c7d
@jstuczyn
only starting RewardedSetUpdater if the config flag is set
ea378aa
@jstuczyn
nym-api compiling with coconut feature
a94397b
@jstuczyn
removed redundant process_runner
0263790
@jstuczyn
removed generic aspect of nym-api nyxd::Client
e1473eb
@jstuczyn
signle entry point for starting nym_contract_cache
a2b6068
@jstuczyn
do not eagerly grab instances of managed state
cd98496
@jstuczyn
inlining openapi route spec
f11af00
@jstuczyn
CirculatingSupplyResponse type
41d6181
@jstuczyn
fixed compilation of coconut tests
6dcdb83
@jstuczyn
calculating circulating supply based on mixmining reserve and vesting…
47386fa 
… tokens
@jstuczyn
separated different variants of caching intervals
6163bf6
@jstuczyn
allow nym-api to specify address of the vesting contract
23d42ba
@jstuczyn
fixed types export
f93c4fe
@jstuczyn
renamed the query on the vesting contract
38b7272
@jstuczyn
reorganised startup procedure and made all start methods independent …
a428c95 
…from rocket
@jstuczyn
cleaned up startup procedure for nym-api
4cac78b
@jstuczyn
startup checks for rewarding permisssions
ad3177f
@jstuczyn jstuczyn merged commit 5709c45 into develop Jan 12, 2023
@jstuczyn jstuczyn deleted the feature/circulating-supply branch January 12, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durch durch Awaiting requested review from durch durch is a code owner

@futurechimp futurechimp Awaiting requested review from futurechimp

@neacsu neacsu Awaiting requested review from neacsu

@octol octol Awaiting requested review from octol

@mfahampshire mfahampshire Awaiting requested review from mfahampshire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Circulating supply api endpoint (read the note inside before testing/deploying)
2 participants
@jstuczyn @futurechimp