Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outfox integration #3331

Merged
merged 15 commits into from
May 29, 2023
Merged

Outfox integration #3331

merged 15 commits into from
May 29, 2023

Conversation

durch
Copy link
Contributor

@durch durch commented Apr 19, 2023 •
edited
Loading

Good to merge

  • Works on foxyfox with Outfox
  • Works on mainnet with Sphinx

@durch durch marked this pull request as ready for review April 20, 2023 09:56
@durch durch mentioned this pull request Apr 20, 2023
Closed
5 tasks
jstuczyn
jstuczyn reviewed Apr 20, 2023
View reviewed changes
common/mixnode-common/src/packet_processor/processor.rs Outdated Show resolved Hide resolved
common/nymsphinx/framing/src/codec.rs Outdated Show resolved Hide resolved
common/nymsphinx/params/src/packet_modes.rs Outdated Show resolved Hide resolved
common/nymsphinx/params/src/packet_sizes.rs Outdated Show resolved Hide resolved
mixnode/src/node/packet_delayforwarder.rs Outdated Show resolved Hide resolved
nym-outfox/src/lib.rs Outdated Show resolved Hide resolved
nym-outfox/tests/unittests.rs Outdated Show resolved Hide resolved
@durch durch changed the title Outfox framing compat Outfox compat Apr 20, 2023
@durch
Copy link
Contributor Author

durch commented Apr 20, 2023

@jstuczyn Adressed all the things, and merged the merge train, I think the only thing left is adding Outfox sending too clients

@durch durch mentioned this pull request Apr 27, 2023
Closed
@durch
Copy link
Contributor Author

durch commented May 1, 2023

Hold off on the merge, I still might get a few tweaks in

@durch durch changed the title Outfox compat Outfox integration May 22, 2023
durch and others added 13 commits May 27, 2023 10:57
@durch
Experiment with serde
8ab4988
@durch
Framed encoding serde POC
6acce42
@durch
Outfox framing
7e78733
@durch
Outfox rest compat (#3333)
a985136 
* Outfox forwarding compat

* Tidy up interface

* PacketSize compat
@durch
Address PR comments
1029590
@durch
Rebase on develop
4490f15 
commit 342883f
Author: durch <durch@users.noreply.github.com>
Date:   Thu Apr 27 09:17:18 2023 +0200

    Put back PacketType 1

commit 61a0ee5
Author: Tommy Verrall <tommyvez@protonmail.com>
Date:   Wed Apr 26 16:37:29 2023 +0100

    change output for cpu-cycle management logs

commit 3956109
Author: Tommy Verrall <tommy@nymtech.net>
Date:   Wed Apr 26 12:13:22 2023 +0100

    change the workflow file to build with cpucycles

commit 8d725b1
Author: durch <durch@users.noreply.github.com>
Date:   Mon Apr 24 13:14:58 2023 +0200

    Outfox client compat

commit 4d166c3
Author: durch <durch@users.noreply.github.com>
Date:   Fri Apr 21 00:30:46 2023 +0200

    Address PR comments

commit 145c3c1
Author: durch <durch@users.noreply.github.com>
Date:   Fri Apr 21 00:12:35 2023 +0200

    Rename PacketMode

commit cbd654d
Author: Drazen Urch <drazen@urch.eu>
Date:   Thu Apr 20 23:59:40 2023 +0200

    Outfox rest compat (#3333)

    * Outfox forwarding compat

    * Tidy up interface

    * PacketSize compat

commit e7be91a
Author: durch <durch@users.noreply.github.com>
Date:   Wed Apr 19 16:36:48 2023 +0200

    Remove serde cruft

commit 582e7d5
Author: durch <durch@users.noreply.github.com>
Date:   Wed Apr 19 16:24:09 2023 +0200

    Outfox framing

commit 6464da5
Author: durch <durch@users.noreply.github.com>
Date:   Tue Apr 18 22:23:02 2023 +0200

    Framing compat

commit d5e77e4
Author: durch <durch@users.noreply.github.com>
Date:   Tue Apr 18 18:18:54 2023 +0200

    Framed encoding serde POC

commit f086f9c
Author: durch <durch@users.noreply.github.com>
Date:   Tue Apr 18 16:54:21 2023 +0200

    Experiment with serde
@durch
Client tweaks
7228a95
@durch
Speed up from_plaintext
149c1d4
@durch
SurbAcks
4d837a0
@durch
More work on the reciever end, and outfox format
19c4b32
@durch
Cleanup and fmt
2577235
@durch
Wrap up rebase
73d9d3f
@durch
Happy clippy
b7ca938
@durch durch merged commit b5c8b69 into develop May 29, 2023
@durch durch deleted the outfox-compat-framing branch May 29, 2023 08:05
neacsu added a commit that referenced this pull request Jun 29, 2023
@neacsu
Revert "Outfox integration (#3331)"
a06d25a 
This reverts commit b5c8b69.
@neacsu neacsu restored the outfox-compat-framing branch June 29, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuczyn jstuczyn jstuczyn left review comments

@aniampio aniampio Awaiting requested review from aniampio

@futurechimp futurechimp Awaiting requested review from futurechimp

@neacsu neacsu Awaiting requested review from neacsu

@octol octol Awaiting requested review from octol octol is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outfox integration
2 participants
@durch @jstuczyn