-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service provider directory support in nym-api, nym-cli, validator-client #3332
Conversation
The way we should test this IMHO is the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
||
/// Deposit to be made to the service provider directory, in curent DENOMINATION (e.g. 'unym') | ||
#[clap(long)] | ||
pub deposit: u128, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it would make sense to change the deposit
to be an explicit Coin
so people wouldnt be confused by unym vs nym. But it's more of a note for the future
72dd0cb
to
0dfd1cc
Compare
Description
Closes: #3296
Closes: #3241
Closes: #3242
Closes: #3334